Make Reaper sell allowance a labeled first step - #39
Merged
Merged
Conversation
The first wallet prompt is an ERC-20 allowance, not the sale. Spell out allow-then-sell copy and keep approve confirmation from looking like a completed sell. Co-authored-by: Rastsislau Lipski <rastsislaux@users.noreply.github.com>
rastsislaux
marked this pull request as ready for review
August 18, 2026 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selling $NETH still takes two transactions (exact ERC-20 approve, then
sellToReaper). The Grave Reaper pane now says so, so the first wallet confirm is not mistaken for a completed sale.What the seller sees
The on-chain flow is unchanged.