-
Notifications
You must be signed in to change notification settings - Fork 2
Release 2.1.0 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 2.1.0 #30
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
5da6cb5
[NAB-358] - Release 2.1.0
mazarijuraj db18e62
[NAB-369] - Boolean field description
mazarijuraj e7fb00d
add initial loading with logo
tuplle 680a528
Merge pull request #16 from netgrif/feature/initial-loading
mazarijuraj 71252a3
[NAB-359] - Task ref with multiple init values
mazarijuraj b6b069f
[NAB-359] - Task ref with multiple init values
mazarijuraj 44d395f
[NAB-359] - Task ref with multiple init values
mazarijuraj 5a60cb3
[NAB-359] - Task ref with multiple init values
mazarijuraj 360655b
[NAB-362] - Action editor interpolated string highlight
mazarijuraj 2996490
[NAB-373] - Place reference value not changed on simulation
mazarijuraj 97fe0e9
Merge pull request #15 from netgrif/NAB-369
mazarijuraj 2b0ecfb
Merge pull request #18 from netgrif/NAB-373
mazarijuraj b60c760
Merge pull request #17 from netgrif/NAB-362
mazarijuraj 3f706cb
[NAB-367] - One-click variable arc change
mazarijuraj ac7e0cd
[NAB-367] - One-click variable arc change
mazarijuraj ba28244
[NAB-367] - One-click variable arc change
mazarijuraj ab85397
[NAB-367] - One-click variable arc change
mazarijuraj 58830d9
[NAB-368] - Component parameters
mazarijuraj d18b24b
[NAB-368] - Component parameters
mazarijuraj e9793d9
[NAB-368] - Component parameters
mazarijuraj 9fbded8
[NAB-372] - Element move after dialog save
mazarijuraj 47af2f7
Merge pull request #20 from netgrif/NAB-372
mazarijuraj ff8cb62
Merge branch 'next' into NAB-367
mazarijuraj 7aa8b26
[NAB-367] - One-click variable arc change
mazarijuraj dc056d9
[NAB-367] - One-click variable arc change
mazarijuraj 4bb65be
Merge pull request #19 from netgrif/NAB-367
mazarijuraj 801cd32
[NAB-358] - Release 2.1.0
mazarijuraj 690b835
[NAB-371] Safari black canvas
camperko ff5bf06
[NAB-359] Task ref with multiple init values
camperko 9201b63
Merge remote-tracking branch 'origin/next' into NAB-359
camperko 64308d0
Merge remote-tracking branch 'origin/next' into NAB-368
camperko 60a15d2
[NAB-368] Component parameters
camperko eec18ea
[NAB-377] Incorrect Demo Link
camperko 09312e1
[NAB-376] Action Edtitor Groovy tutorial
camperko 5bf80c6
[NAB-374] Right click shows default browser context menu
camperko 9b380eb
[NAB-374] Right click shows default browser context menu
camperko 25f819f
Merge pull request #25 from netgrif/NAB-374
mazarijuraj 0be33a8
Merge pull request #24 from netgrif/NAB-376
mazarijuraj dc733e6
Merge pull request #23 from netgrif/NAB-377
mazarijuraj 956a98c
[NAB-359] - Task ref with multiple init values
mazarijuraj 9983fc8
Merge pull request #21 from netgrif/NAB-359
mazarijuraj dd50cba
Merge branch 'next' into NAB-368
mazarijuraj 020ecfd
[NAB-375] Variables with no init values referenced in arcs will cause…
camperko c9b7fa2
[NAB-368] Component parameters
camperko 1c6ba63
Merge remote-tracking branch 'origin/NAB-368' into NAB-368
mazarijuraj f5df106
Merge pull request #22 from netgrif/NAB-368
mazarijuraj 77a3d63
[NAB-378] Global role support
tuplle e5daa2f
[NAB-375] Variables with no init values referenced in arcs will cause…
tuplle 3c41e30
Merge pull request #26 from netgrif/NAB-375
tuplle 68377b5
Merge pull request #27 from netgrif/NAB-378
tuplle c173387
increase version to 2.1.0-RC.3
tuplle 6a4460d
[NAB-375] Variables with no init values referenced in arcs will cause…
mazarijuraj 6094167
[NAB-358] Release 2.1.0
mazarijuraj 9528c05
[NAB-358] Release 2.1.0
mazarijuraj cf2a8b5
[NAB-358] Release 2.1.0
mazarijuraj fc78a5a
[NAB-358] Release 2.1.0
mazarijuraj d0c96e9
[NAB-358] Release 2.1.0
mazarijuraj 636a552
increase version to 2.1.0-RC.7
tuplle 4142aaa
[NAB-389] Cannot change the number of columns in form editor
Kovy95 62182da
[NAB-389] Cannot change the number of columns in form editor
Kovy95 5b1962f
Merge pull request #29 from netgrif/NAB-389
tuplle 8f31d26
increase version to 2.1.0-RC.8
tuplle 2a2bf47
[NAB-390] Change demo link to eTask
mazarijuraj e558a7a
Merge pull request #31 from netgrif/NAB-390
tuplle 5cc1e88
Display application version in the sidenav
tuplle 9f96b8f
Reorganize imports across components and services
tuplle e17a8b6
[NAB-358] Release 2.1.0
mazarijuraj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,4 +87,4 @@ | |
| padding-right: 9px; | ||
| height: 42px; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/app/dialogs/dialog-arc-attach/dialog-arc-attach.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 5 additions & 3 deletions
8
src/app/dialogs/dialog-change-data/dialog-change-data.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/app/dialogs/dialog-delete-model/dialog-delete-model.component.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/app/dialogs/dialog-delete-model/dialog-delete-model.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/app/dialogs/dialog-local-storage-model/dialog-local-storage-model.component.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/app/dialogs/dialog-local-storage-model/dialog-local-storage-model.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
src/app/dialogs/dialog-manage-roles/dialog-manage-roles.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/app/dialogs/dialog-marking-change/dialog-marking-change.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <h2 mat-dialog-title>Change marking of place {{CanvasNodeElement.pretty(place)}}</h2> | ||
| <mat-dialog-content class="netgrif-input"> | ||
| <mat-form-field fxFlex> | ||
| <mat-label>Tokens</mat-label> | ||
| <input type="number" min="0" step="1" matInput [(ngModel)]="place.marking" [formControl]="markingCtrl"> | ||
| <mat-error *ngIf="markingCtrl.errors && markingCtrl.errors.required">Number of tokens is required</mat-error> | ||
| <mat-error *ngIf="markingCtrl.errors && markingCtrl.errors.validMultiplicity">Number of tokens must be a non-negative integer</mat-error> | ||
| </mat-form-field> | ||
| </mat-dialog-content> | ||
| <mat-dialog-actions> | ||
| <button mat-flat-button color="primary" [mat-dialog-close]="place.marking" [disabled]="markingCtrl.invalid"> | ||
| <mat-icon>done</mat-icon> | ||
| <span>Save</span> | ||
| </button> | ||
| </mat-dialog-actions> |
8 changes: 8 additions & 0 deletions
8
src/app/dialogs/dialog-marking-change/dialog-marking-change.component.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| mat-dialog-content { | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| mat-dialog-actions { | ||
| justify-content: flex-end; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Shared FormControl breaks multi-field editing.
All input fields in the loop share the same
valueCtrlFormControl. This means:Each data item needs its own FormControl or the component should use template-driven forms with separate
ngModelbindings without a shared FormControl.Since the AI summary indicates valueCtrl was introduced in the TypeScript file, you'll need to refactor the component to either:
Option 1: Remove the FormControl and use template-driven validation:
And update the save button to check if any data.value is invalid.
Option 2: Use FormArray with individual controls for each data item (requires more changes in the TypeScript file).
🤖 Prompt for AI Agents