ci: re-enable armv7lh in cross-compile workflow#777
Closed
leoparente wants to merge 2 commits into
Closed
Conversation
Uncomments the armv7lh matrix entry in build_cross.yml's pkvisor job and adds ldflags: "-static" so it matches the x86_64 and aarch64 siblings. The musl-cross toolchain tarball is still hosted in the repo's `toolchains` GitHub release; the downstream pkvisor-cli matrix already includes armv7lh, so the Go binary cross-build is unaffected. Restores static armv7 pktvisord / pktvisor-reader artifacts that have been disabled since the 2023 docker-folder cleanup (32b15f2). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
LCOV of commit
|
The protobuf 6.33.5 / v34.x cmake hardcodes `libprotobuf` (not the
function's target parameter) in its libatomic linkage branch:
function(protobuf_configure_target target)
if(protobuf_LINK_LIBATOMIC)
target_link_libraries(libprotobuf PRIVATE atomic)
endif()
When protobuf_LINK_LIBATOMIC=ON and the function is called for
libprotobuf-lite *before* libprotobuf is created, cmake fails:
Cannot specify link libraries for target "libprotobuf" which is
not built by this project.
This is upstream protobuf bug, fixed on main in PR #24068 but not
in any tagged release through v34.x. The try_compile that sets
protobuf_LINK_LIBATOMIC fires only on 32-bit ARM (no native 64-bit
atomics) — so the failure is armv7-specific. x86_64 and aarch64
have native 64-bit atomics, protobuf_LINK_LIBATOMIC stays OFF, and
the buggy branch is never reached.
Force protobuf_LINK_LIBATOMIC=OFF via a per-package conan conf in
the host profile. Safe for static-library consumers (protobuf is
built shared=False) because final pktvisor link already pulls in
-latomic via -DCMAKE_CXX_STANDARD_LIBRARIES=-latomic. The conf
is a no-op for x86_64/aarch64 where the auto-detect already
yields OFF.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this works without other changes
Risk
First CI run rebuilds all conan deps for `armv7hf` (no cache exists for the new arch). If a recipe surfaces armv7-specific issues — likely candidates: `opentelemetry-cpp`, `protobuf`, `libpcap` — they'll be fixed as follow-up commits on this PR.
Test plan