Skip to content

Added comments to output.#84

Merged
netbe merged 24 commits into
netbe:masterfrom
borut-t:master
Jan 29, 2016
Merged

Added comments to output.#84
netbe merged 24 commits into
netbe:masterfrom
borut-t:master

Conversation

@borut-t

@borut-t borut-t commented Jan 12, 2016

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread lib/babelish/csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 4) spaces for indentation.

@netbe

netbe commented Jan 12, 2016

Copy link
Copy Markdown
Owner

@borut-t thanks! could you add a unit test to it?

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.
Space inside { missing.
Space inside } missing.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

@borut-t

borut-t commented Jan 12, 2016

Copy link
Copy Markdown
Contributor Author

@netbe Ok. I've made tests. When can I expect this to be released?

@netbe

netbe commented Jan 12, 2016

Copy link
Copy Markdown
Owner

@borut-t I'll try this week, I need to fix #79 for the release, two more things:

  • Could you fix the style issues by @houndci ?
  • Would be great if you add support for comments from android to csv (this could be a second PR) :)

Thanks again for your contribution I

@borut-t

borut-t commented Jan 29, 2016

Copy link
Copy Markdown
Contributor Author

@netbe Are there any guidelines about formatting cos I could not get this:

Align the parameters of a method call if they span more than one line.
Space inside { missing.
Space inside } missing.

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.
Trailing whitespace detected.

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.
Tab detected.

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.
Tab detected.

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected token tCOMMA
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected token tCOMMA
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

Comment thread test/babelish/test_csv2android.rb Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected token tCOMMA
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

@borut-t

borut-t commented Jan 29, 2016

Copy link
Copy Markdown
Contributor Author

@netbe Finally was able to clean all style issue. Could we proceed?

netbe added a commit that referenced this pull request Jan 29, 2016
Added comments to output.
@netbe netbe merged commit 6a58262 into netbe:master Jan 29, 2016
@netbe

netbe commented Jan 29, 2016

Copy link
Copy Markdown
Owner

yes great thks!

@coveralls

coveralls commented Jan 11, 2018

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-53.8%) to 34.405% when pulling 70521d2 on borut-t:master into 6830aa9 on netbe:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants