Skip to content

Android Default language management#120

Open
filippodelfra wants to merge 2 commits into
netbe:masterfrom
filippodelfra:hotfix/android_default_lang
Open

Android Default language management#120
filippodelfra wants to merge 2 commits into
netbe:masterfrom
filippodelfra:hotfix/android_default_lang

Conversation

@filippodelfra

Copy link
Copy Markdown

Hi,
I've added the management of default language in csv2android command.
If a default language is set, the translations will be stored in the "values" folder.
Also, I have added a test set.

Thanks

Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread test/babelish/commands/test_command_csv2android.rb
Comment thread lib/babelish/csv2android.rb
@ExPl0siF

ExPl0siF commented May 26, 2020

Copy link
Copy Markdown

Hey @filippodelfra and @netbe

 I've try to use this functionality but it doesn't seems to work, here is my .babelish config:

filename: Localization.csv
default_lang: "en"
langs:
English: "en"
French: "fr"
comments_column: 0
keys_column: 1
csv_separator: ';'

I've tried to change the default_lang with multiple things, like English, en, en-US etc but it doesn't seems to work with this pull request ... Do I am doing something wrong? I also tried with the command line variable but it doesn't work too

Thanks in advance

@netbe

netbe commented Jun 8, 2020

Copy link
Copy Markdown
Owner

@ExPl0siF could you be more specific about what you expect?

@filippodelfra default_lang option is supposed to be fallback on values (if a value is not translated it will use the one in the default_lang
If you want to overwrite the location of files, it might be with the output_dir and output_basename

@netbe netbe added the Android label Jun 8, 2020
@ExPl0siF

ExPl0siF commented Jun 10, 2020

Copy link
Copy Markdown

@ExPl0siF could you be more specific about what you expect?

@filippodelfra default_lang option is supposed to be fallback on values (if a value is not translated it will use the one in the default_lang
If you want to overwrite the location of files, it might be with the output_dir and output_basename

@netbe I just want my Babelish config to output one values and one values-fr, but atm I only get one values-en and one values-fr, I juste want to remove the -en on my default langage :) Thanks in advance

@enasaz9

enasaz9 commented Nov 21, 2023

Copy link
Copy Markdown

@ExPl0siF did you manage to solve this issue?

@ExPl0siF

Copy link
Copy Markdown

@ExPl0siF did you manage to solve this issue?

Nope ... Never got an answer ... So I wrote a shell script that run babelish and then I mv the bad folder name

@enasaz9

enasaz9 commented Nov 21, 2023

Copy link
Copy Markdown

@ExPl0siF Thanks for your swift reply, really appreciated :)
ok, I will do the same.

@netbe

netbe commented Feb 7, 2024

Copy link
Copy Markdown
Owner

@ExPl0siF it's surely a bit late but perhaps in your config, default_lang should be :

default_lang: "English"  

instead of:

default_lang: "en"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants