fix: add missing @classmethod decorator to load_model_tokenizer#22
Open
amathxbt wants to merge 1 commit into
Open
fix: add missing @classmethod decorator to load_model_tokenizer#22amathxbt wants to merge 1 commit into
amathxbt wants to merge 1 commit into
Conversation
The load_model_tokenizer method in HuggingFaceModelMixin was missing the @classmethod decorator, causing a TypeError when called on the class. Without it, 'cls' receives the first positional argument (model_name) instead of the class, making the method uncallable as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
load_model_tokenizermethod inHuggingFaceModelMixin(demo/nesa/backend/hf_models.py) is missing the@classmethoddecorator.Impact: When the method is called on the class (e.g.
HuggingFaceModelMixin.load_model_tokenizer(model_name)), Python treats it as a regular instance method. This meansclsreceivesmodel_nameinstead of the class, andmodel_nameis never received — resulting in aTypeErrorat runtime.The companion method
perform_inferencein the same class correctly uses@classmethod.Fix
Added the missing
@classmethoddecorator before the method definition.How to reproduce