Skip to content

fix(cso): normalize incidentDate/submittedDate to a uniform string on write #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nesanders merged 1 commit into from
Aug 22, 2026
Merged

fix(cso): normalize incidentDate/submittedDate to a uniform string on write #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion analysis/EEA_DP_CSO_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ def load_data_cso(self, pick_start: Optional[date]=None, pick_end: Optional[date
print(f'Loading EEA Data Portal CSO data')
disk_engine = get_engine()
data_cso = pd.read_sql_query(self.EEA_DP_CSO_QUERY, disk_engine)
data_cso['incidentDate'] = pd.to_datetime(data_cso['incidentDate'])
# format='mixed': incidentDate is written as a uniform string by
# get_eea_dp_cso.py, but this is the first parse of the raw column and a
# defensive fallback in case any stored value ever has a different (but
# still valid) format than the rest — a strict single-format parse would
# crash the whole dashboard build on one bad row.
data_cso['incidentDate'] = pd.to_datetime(data_cso['incidentDate'], format='mixed')
data_cso.rename(columns={
'volumnOfEvent': self.discharge_vol_col,
'outfallId': 'cso_id'
Expand Down
Loading
Loading