tui: integrate ckb-tui into ckb-cli - #684
Closed
Xcodes-chain wants to merge 11 commits into
Closed
Conversation
# Conflicts: # Cargo.lock # src/subcommands/molecule.rs # src/utils/rpc/types.rs
Author
|
Closed because this regression should be submitted through ckb-py-integration-test instead of ckb-cli. The ckb-cli CI-only PR was opened by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is opened to run CI regression for the ckb-tui integration based on
Officeyutong/ckb-cli:ckb-tui-integration.Current HEAD:
58cfc32 update ckb-tuicde7293 show friendly message when indexer is not enabledLocal validation
Passed locally:
cargo build --locked --releasemake testcargo test --locked -p ckb-tui explains_how_to_enable_indexer_when_rpc_method_is_missing -- --nocaptureckb-cli tuiagainst local CKB0.209.0get_cellsreturnsMethod not foundas expected, and the latest ckb-tui maps it to a user-friendly indexer-unavailable messageckb run --indexerexposesget_indexer_tipandget_cells; miner lock script query returns live cellsNote
Full local
make integrationwas stopped after confirming the CKB binary build path because this Mac environment lackspkg-config/ OpenSSL development discovery for the test harness. CI pods should have the required environment and will be used as the source of truth for integration regression.