Fix dependency-audit: bump fast-uri override to clear HIGH advisories - #156
Conversation
Four fast-uri advisories (GHSA-5jgf-p345-68v8, GHSA-f65p-4m7j-42xc, GHSA-fph4-wmhf-6fwf, GHSA-jqff-g426-hqxp) all affect versions <3.1.6. The existing override pinned fast-uri to ^3.1.5, which is itself in the vulnerable range. Bump to ^3.1.6 (resolves to 3.1.7), staying within ajv@8.18.0's declared ^3.0.1 requirement.
Bump floor from ^3.1.6 to ^3.1.7 to match the version actually installed and audited, per code review feedback. Both ranges resolve to 3.1.7 in this lockfile, but pinning the floor to the untested 3.1.6 left a gap: a future install landing exactly on 3.1.6 would never have been verified against the advisories.
|
Independent Agent Code Review trail Round 1 — flagged: the override floor was set to Also noted (informational, not actioned): Round 2 — Unresolved after review: none. |
What changed
Bumps the existing
overrides.fast-uripin inpackage.jsonfrom^3.1.5to^3.1.7, resolvingfast-urito3.1.7inpackage-lock.json.Why
Four new HIGH-severity advisories were published against
fast-uriversions<3.1.6:The repo already carries a
fast-urioverride (from #61, for a prior advisory round), pinned to^3.1.5— which is itself in the newly-vulnerable range. This was failingnpm audit --audit-level=highon every open PR (main would fail too if re-audited, sincenpm auditqueries the live advisory DB rather than a snapshot).fast-uriis transitive:conf@15.1.0→ajv@8.18.0→fast-uri.ajv@8.18.0declaresfast-uri: ^3.0.1, so the fix stays within the 3.x major rather than jumping tofast-uri@4.x(which would fall outside ajv's declared range).The override floor is set to
^3.1.7— the exact version verified locally and recorded in the lockfile — rather than^3.1.6(the first version outside all four advisory ranges), so the pin can't silently resolve to an untested patch version.Verification
npm ci(mirrors thedependency-auditCI job) →npm audit --audit-level=highexits 0, only the 2 pre-existing moderate advisories (@humanfs/node,fflate) remain, both below thehighgate and out of scope for this PR.npm run lint— clean.npm run test:ci— 837 tests passing across 28 files.No issue to close — this is CI maintenance triggered by newly-published advisories, not a tracked issue.