fix: this checks that the course has an end date before rendering cer… - #65
Merged
Merged
Conversation
johanseto
reviewed
Oct 2, 2025
johanseto
left a comment
johanseto
left a comment
There was a problem hiding this comment.
The change is small. Anyway, I tried to replicate the error msg and I could do it, @andrey-canon could you tell me what else is missing in my configurations
Screencast.from.02-10-25.09.11.45.webm
andrey-canon
force-pushed
the
teak-mig/FUTUREX-1281
branch
from
October 7, 2025 17:00
1f0c8dc to
2dc5280
Compare
andrey-canon
changed the base branch from
teak-mig/FUTUREX-1285
to
open-release/teak.nelp
October 7, 2025 17:02
johanseto
self-requested a review
October 20, 2025 21:06
johanseto
approved these changes
Oct 20, 2025
andrey-canon
force-pushed
the
teak-mig/FUTUREX-1281
branch
from
October 21, 2025 16:56
2dc5280 to
0886b3a
Compare
andrey-canon
temporarily deployed
to
open-release/teak.nelp
October 21, 2025 16:56 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
andrey-canon
temporarily deployed
to
open-release/teak.nelp
October 21, 2025 16:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new condition that limits the
certificate statusmessage based on the end date. This is a migration pr of #39Issue # 1281
Before
After
How to test
To replicate this issue, the response from
{lms_host}/api/course_home/progress/{course_id}must contain"certificate_data": null. If your course is new, you only need to set a valid user mode, and that’s enough.