Update tasmanian-mismatch to 2.0.5 - #75
Closed
aerijman wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The module currently disables -e/pipefail in a way that can mask real task failures, and the updated invocation changes sampling/filters in ways that need confirmation to match intended pipeline behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the tasmanian Nextflow module to use tasmanian-mismatch version 2.0.5, adapting the process to a new/updated CLI while keeping the same output artifact (${library}.tasmanian.csv) for downstream aggregation in the EM-seq pipeline.
Changes:
- Bump
bioconda::tasmanian-mismatchto2.0.5and remove the explicitsamtoolsdependency from the process conda env. - Switch from a
samtools view | head | run_tasmanianpipeline to a directtasmanian-mismatchinvocation with explicit filtering flags. - Update versions reporting for MultiQC to reference
tasmanian-mismatch(currently via a static placeholder string).
File summaries
| File | Description |
|---|---|
| modules/tasmanian.nf | Updates the tasmanian stats process to run tasmanian-mismatch 2.0.5 directly and adjusts version reporting/output generation accordingly. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
+28
| tasmanian-mismatch ${bam} ${genome_fa} \ | ||
| --position-mode read \ | ||
| --min-base-quality 20 \ | ||
| --min-map-quality 30 \ | ||
| -F 3840 \ |
| tuple val(library), path("${library}.tasmanian.csv"), emit: for_agg | ||
| tuple val("${task.process}"), val('samtools'), eval('samtools --version | head -n 1 | sed \'s/^samtools //\''), topic: versions | ||
| tuple val("${task.process}"), val('tasmanian'), val('*should be* 1.0.9'), topic: versions | ||
| tuple val("${task.process}"), val('tasmanian-mismatch'), val('*should be* 2.0.5'), topic: versions |
Comment on lines
22
to
23
| set +e | ||
| set +o pipefail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.