Skip to content

Add placeholder landing page for Nebari Data Science Pack#92

Open
killua156 wants to merge 10 commits into
nebari-dev:mainfrom
killua156:docs/docusaurus-site
Open

Add placeholder landing page for Nebari Data Science Pack#92
killua156 wants to merge 10 commits into
nebari-dev:mainfrom
killua156:docs/docusaurus-site

Conversation

@killua156

@killua156 killua156 commented May 21, 2026

Copy link
Copy Markdown

Added a placeholder landing page for the Nebari Data Science Pack documentation. Content will be filled in a follow on issue.

Mirrors the docs structure of nebari-rayserve-pack: Diataxis layout,
Yarn + Netlify toolchain, lunr search, Mermaid diagrams, Nebari brand
styling. Deploys automatically from netlify.toml on push to main.
@killua156

Copy link
Copy Markdown
Author

please check and review this when you can @kcpevey.
same as ray serve pack documentation:
cd docs
yarn install
yarn start
Then http://localhost:3000/.

@andrewfulton9 andrewfulton9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments throughout. Note that I am pretty new to nebari so I could be missing some context. Overall I think the content is good, but I find the organization unintuitive. For instance, if I wanted to understand the architecture. Clicking on the reference section wouldn't be my first thought. I would prefer something like:

Introduction
Deployment:

  • Deploy the pack
  • Architecture
  • Configuration Guide
  • Troubleshoot
    User Guides
  • Use the pack from a notebook
    Reference
  • Release Notes
  • Personas

I took the reference section pages from the nebari classic docs.

Comment thread docs/docs/how-tos/use.md Outdated
Comment thread docs/docs/get-started/deploy.md Outdated
Comment thread docs/docs/how-tos/use.md Outdated
Comment thread docs/docs/how-tos/use.md Outdated
Comment thread docs/docs/how-tos/use.md Outdated
Comment thread docs/docs/how-tos/use.md Outdated
Comment thread docs/docs/how-tos/use_pack_from_notebook.md Outdated
Comment thread docs/docs/how-tos/troubleshoot.md Outdated
Comment thread docs/docs/get-started/architecture.md Outdated
@killua156

Copy link
Copy Markdown
Author

I've added some comments throughout. Note that I am pretty new to nebari so I could be missing some context. Overall I think the content is good, but I find the organization unintuitive. For instance, if I wanted to understand the architecture. Clicking on the reference section wouldn't be my first thought. I would prefer something like:

Thank you for your suggested changes and input. I'm new to nebari as well so this helps me a lot. I will make the changes and try to improve the documentation more.

@andrewfulton9

Copy link
Copy Markdown
Collaborator

Also in my experiments when deploying with nebari, I've needed to include routing configurations which I don't see documented here:

    helm:
      releaseName: data-science-pack
      values: |
        nebariapp:
          enabled: true
          routing:
            routes:
              - pathPrefix: /
         ...

Restructure the sidebar to match @andrewfulton9's suggested layout
(Introduction / Deployment / User Guides / Reference) and address all
inline review comments on nebari-dev#92:

- Move Architecture and Troubleshoot under Deployment; extract the
  Configuration guide from deploy.md into its own page; add new
  Release notes and Personas pages under Reference.
- Apply Nebari-classic landing-page voice on intros and section
  indexes (persona-first "If you are..." openers, "Learn how to" CTAs).
- Rename use.md to use_pack_from_notebook.md and strip kubectl/helm
  from end-user pages; route end users to "ask your operator" with
  links to the operator-side fix.
- Replace stale version literals (4.3.2, sha-* image tags, 0.8-repack)
  in prose with links to Chart.yaml / values.yaml + chart-version
  stamps.
- Document the routing.routes gotcha Andrew reported, in three places:
  the ArgoCD example in Deploy, a new "Explicit routing rules" section
  in the Configuration guide, and a Troubleshoot entry for the
  "404 with RoutingReady: True" symptom.
- Add an MLflow integration section, with the wiring pattern sourced
  verbatim from the nebari-mlflow-pack README (extraEnv +
  NetworkPolicy egress on pod port 5000).
- Add a GPU profile example using only the kubespawner_override traits
  the chart's 01-spawner.py documents (node_selector,
  extra_resource_limits, image); cluster-specific labels and runtime
  classes are left as placeholders.
- Add AGENT.md at the repo root: a self-contained docs playbook for
  future agents/contributors covering stack, IA, voice, verification,
  anti-patterns, and the pre-publish checklist.

Refs nebari-dev#89.
@kcpevey kcpevey requested a review from khuyentran1401 June 4, 2026 13:37
Comment thread docs/README.md Outdated
@killua156 killua156 changed the title docs: add Docusaurus site with Netlify deployment docs: add placeholder landing page Jun 10, 2026
@killua156 killua156 changed the title docs: add placeholder landing page Add placeholder landing page Jun 10, 2026
@killua156 killua156 changed the title Add placeholder landing page Add placeholder landing page for Nebari Data Science Pack Jun 10, 2026
Comment thread docs/README.md Outdated

@andrewfulton9 andrewfulton9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the placeholder work looks good. I made a couple of comments. I was able to build and serve this locally

Comment thread docs/README.md Outdated
Comment thread docs/README.md Outdated
…EADME, drop in-progress note from introduction
@killua156

Copy link
Copy Markdown
Author

Suggested changes made.

- docusaurus.config.ts, sidebars.ts, tsconfig.json with typecheck script
- Align deps with nebi: Docusaurus 3.10.1, React 19, @docusaurus/faster,
  @easyops-cn/docusaurus-search-local (drops the webpack pin workaround)
- Switch yarn to npm (package-lock.json)
- Replace deploy-docs.yml with nebi-style build-only docs.yml
@killua156

Copy link
Copy Markdown
Author

@kcpevey Suggested changes made. Also converted the docs setup to TypeScript and simplified the workflow to a build-only check (matching nebi), same as requested on the chat pack. Ready for another look.

@andrewfulton9 andrewfulton9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified commands in the README work as expected.

Comment thread .gitignore Outdated
.env.production.local

npm-debug.log*
yarn-debug.log*

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yarn references can be moved now

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. removing them

@andrewfulton9 andrewfulton9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the docs gh action workflows also deploy to GH pages?

@killua156 killua156 requested a review from kcpevey June 17, 2026 16:08
@killua156

Copy link
Copy Markdown
Author

should the docs gh action workflows also deploy to GH pages?

Not in this PR. I kept it build-only to match the chat and ray-serve packs, which don't deploy either — this is still a placeholder landing page with content coming in a follow-on issue. Adding a deploy step (GH Pages or otherwise) is a bit of a separate decision since we'd want a consistent hosting target across all the packs, and we'd also want it gated so it only publishes from main. Happy to add it here or as a follow-up once we settle on where the docs should live — @kcpevey any preference?

@andrewfulton9 andrewfulton9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion to add the deploy step for gh pages, commit that and update the branch with main and then we are good to go.

Comment thread .github/workflows/docs.yml Outdated
Co-authored-by: Andrew Fulton <andrewfulton9@gmail.com>

@andrewfulton9 andrewfulton9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kcpevey

kcpevey commented Jun 23, 2026

Copy link
Copy Markdown

This PR is on hold until a decision is made on the framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants