Add placeholder landing page for Nebari Data Science Pack#92
Add placeholder landing page for Nebari Data Science Pack#92killua156 wants to merge 10 commits into
Conversation
Mirrors the docs structure of nebari-rayserve-pack: Diataxis layout, Yarn + Netlify toolchain, lunr search, Mermaid diagrams, Nebari brand styling. Deploys automatically from netlify.toml on push to main.
|
please check and review this when you can @kcpevey. |
andrewfulton9
left a comment
There was a problem hiding this comment.
I've added some comments throughout. Note that I am pretty new to nebari so I could be missing some context. Overall I think the content is good, but I find the organization unintuitive. For instance, if I wanted to understand the architecture. Clicking on the reference section wouldn't be my first thought. I would prefer something like:
Introduction
Deployment:
- Deploy the pack
- Architecture
- Configuration Guide
- Troubleshoot
User Guides - Use the pack from a notebook
Reference - Release Notes
- Personas
I took the reference section pages from the nebari classic docs.
Thank you for your suggested changes and input. I'm new to nebari as well so this helps me a lot. I will make the changes and try to improve the documentation more. |
|
Also in my experiments when deploying with nebari, I've needed to include routing configurations which I don't see documented here: |
Restructure the sidebar to match @andrewfulton9's suggested layout (Introduction / Deployment / User Guides / Reference) and address all inline review comments on nebari-dev#92: - Move Architecture and Troubleshoot under Deployment; extract the Configuration guide from deploy.md into its own page; add new Release notes and Personas pages under Reference. - Apply Nebari-classic landing-page voice on intros and section indexes (persona-first "If you are..." openers, "Learn how to" CTAs). - Rename use.md to use_pack_from_notebook.md and strip kubectl/helm from end-user pages; route end users to "ask your operator" with links to the operator-side fix. - Replace stale version literals (4.3.2, sha-* image tags, 0.8-repack) in prose with links to Chart.yaml / values.yaml + chart-version stamps. - Document the routing.routes gotcha Andrew reported, in three places: the ArgoCD example in Deploy, a new "Explicit routing rules" section in the Configuration guide, and a Troubleshoot entry for the "404 with RoutingReady: True" symptom. - Add an MLflow integration section, with the wiring pattern sourced verbatim from the nebari-mlflow-pack README (extraEnv + NetworkPolicy egress on pod port 5000). - Add a GPU profile example using only the kubespawner_override traits the chart's 01-spawner.py documents (node_selector, extra_resource_limits, image); cluster-specific labels and runtime classes are left as placeholders. - Add AGENT.md at the repo root: a self-contained docs playbook for future agents/contributors covering stack, IA, voice, verification, anti-patterns, and the pre-publish checklist. Refs nebari-dev#89.
andrewfulton9
left a comment
There was a problem hiding this comment.
In general, the placeholder work looks good. I made a couple of comments. I was able to build and serve this locally
…EADME, drop in-progress note from introduction
|
Suggested changes made. |
- docusaurus.config.ts, sidebars.ts, tsconfig.json with typecheck script - Align deps with nebi: Docusaurus 3.10.1, React 19, @docusaurus/faster, @easyops-cn/docusaurus-search-local (drops the webpack pin workaround) - Switch yarn to npm (package-lock.json) - Replace deploy-docs.yml with nebi-style build-only docs.yml
|
@kcpevey Suggested changes made. Also converted the docs setup to TypeScript and simplified the workflow to a build-only check (matching nebi), same as requested on the chat pack. Ready for another look. |
| .env.production.local | ||
|
|
||
| npm-debug.log* | ||
| yarn-debug.log* |
There was a problem hiding this comment.
The yarn references can be moved now
andrewfulton9
left a comment
There was a problem hiding this comment.
should the docs gh action workflows also deploy to GH pages?
Not in this PR. I kept it build-only to match the chat and ray-serve packs, which don't deploy either — this is still a placeholder landing page with content coming in a follow-on issue. Adding a deploy step (GH Pages or otherwise) is a bit of a separate decision since we'd want a consistent hosting target across all the packs, and we'd also want it gated so it only publishes from |
Co-authored-by: Andrew Fulton <andrewfulton9@gmail.com>
|
This PR is on hold until a decision is made on the framework |
Added a placeholder landing page for the Nebari Data Science Pack documentation. Content will be filled in a follow on issue.