Skip to content

Document docker and helm tags#146

Open
killua156 wants to merge 3 commits into
nebari-dev:mainfrom
killua156:document-tags
Open

Document docker and helm tags#146
killua156 wants to merge 3 commits into
nebari-dev:mainfrom
killua156:document-tags

Conversation

@killua156

Copy link
Copy Markdown
Contributor

Documents available docker and helm tags in the README, and posts the docker and helm tags of the latest commit as separate sticky comments on PRs.

Closes #143.

@killua156

Copy link
Copy Markdown
Contributor Author

Used marocchino/sticky-pull-request-comment to post the docker and helm tags as two sticky comments that update on each build.

@killua156

Copy link
Copy Markdown
Contributor Author

fork PRs get a read-only GITHUB_TOKEN, so the comment jobs can't post there, right now they just skip (this PR is from my fork, so you can see them skipped). Do we want to keep this to in-repo PRs only, or also cover forks? Covering forks means switching to pull_request_target, which runs with a write token in the base-repo context and needs care to avoid checking out untrusted code with secrets.

cc: @pmeier

Comment thread README.md Outdated
Comment thread README.md Outdated
Address review: tags use the v$SEMVER string, rename <n> to <pr>, and
drop the note about tags being posted as PR comments.
@killua156

Copy link
Copy Markdown
Contributor Author

Done ,applied the suggestion with the v-prefixed examples, and propagated → to the docker and helm tag tables as well so the legend and tables stay consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document docker and helm tags better

2 participants