Skip to content

5.0.1 updates#2

Open
elastickent wants to merge 18 commits into
nbs-system:masterfrom
elastickent:master
Open

5.0.1 updates#2
elastickent wants to merge 18 commits into
nbs-system:masterfrom
elastickent:master

Conversation

@elastickent

Copy link
Copy Markdown

Updated version and new paths to dependencies. Also updated the readme to include 5.0.1 build and install steps.

@jvoisin

jvoisin commented Nov 25, 2016

Copy link
Copy Markdown

Please do not bundle binary files (like .zip) inside the git repository.

@elastickent

Copy link
Copy Markdown
Author

Sure thing, thanks!

@jvoisin

jvoisin commented Nov 28, 2016

Copy link
Copy Markdown

@elastickent We're not using 5.0.1 currently, and we'd like to keep compatibility with our current used version (Kibana 2.x), and I think that this MR would break it.

What is the best practise here?
A try-catch or some kind of fallback? Doing several branches/versions?

(We're not javascript super-pro, sorry :/ )

@jvoisin jvoisin self-assigned this Nov 28, 2016
@jvoisin

jvoisin commented Nov 30, 2016

Copy link
Copy Markdown

Thank you for updating the screenshot, but can you please answer the question in my previous comment? Thank you.

@xarkes

xarkes commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

Also, maybe unrelated, in the gif you added, the refresh time is different than the timing window (10 seconds vs 1 minute). Kibana is going to fetch events from last minute and do it every 10 seconds, so you are going to see the same events many time (and more than it should). I am not sure this was clearly explained in the readme file.

@elastickent

Copy link
Copy Markdown
Author

Great question. Kibana's plugin interface is not stable release to release, so separate versions seem to make the most sense to me.

Thanks for catching the timing issue in the gif.

@jvoisin

jvoisin commented Jan 9, 2017

Copy link
Copy Markdown

I don't think that we can afford to maintain several versions, especially for Kibana versions that we're not using. What about a try-catch?

@jvoisin jvoisin mentioned this pull request Jan 9, 2017
@artfulhacker

Copy link
Copy Markdown

try catch wont work in the json file. however, what I suggest is maintaining different braches and then update the readme instruction to specify the branch version when they do the git clone

@Caioha

Caioha commented May 16, 2017

Copy link
Copy Markdown

Hi

Anyone can help me?

in package.json I changed the version for 5.4.0.
I can see the mapster in visualization, I can configure, but when I try to start I receive the following message: "Visualize: Cannot read property 'group' of undefined"

@Caioha

Caioha commented May 22, 2017

Copy link
Copy Markdown

Same problem:
Visualize: Cannot read property 'group' of undefined

@purplesrl

purplesrl commented Jan 21, 2018

Copy link
Copy Markdown

Visualize: Cannot read property 'group' of undefined

Disable: Place markers off grid (use geocentroid) in Coordinates and the error goes away.

@pbr0ck3r

pbr0ck3r commented Aug 1, 2018

Copy link
Copy Markdown

Can confirm that this works on 5.2.3 as I have it running in a production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants