Skip to content

fix: redirect FFmpeg stdin to /dev/null to prevent TTY corruption #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berettavexee wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: redirect FFmpeg stdin to /dev/null to prevent TTY corruption #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion streamrip/client/downloadable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ async def concat_audio_files(paths: list[str], out: str, ext: str, max_files_ope
"warning",
outpaths[i],
)
fut = asyncio.create_subprocess_exec(*command, stderr=asyncio.subprocess.PIPE)
fut = asyncio.create_subprocess_exec(*command, stdin=asyncio.subprocess.DEVNULL, stderr=asyncio.subprocess.PIPE)
proc_futures.append(fut)

# Create all processes concurrently
Expand Down
1 change: 1 addition & 0 deletions streamrip/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ async def convert(self, custom_fn: Optional[str] = None):

process = await asyncio.create_subprocess_exec(
*self.command,
stdin=asyncio.subprocess.DEVNULL,
stderr=asyncio.subprocess.PIPE,
)
out, err = await process.communicate()
Expand Down