Skip to content

fix(converter): fall back to native aac encoder when libfdk_aac unavailable #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berettavexee wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(converter): fall back to native aac encoder when libfdk_aac unavailable #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions streamrip/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,18 @@

SAMPLING_RATES = {44100, 48000, 88200, 96000, 176400, 192000}

def _check_libfdk_aac() -> bool:
try:
import subprocess
result = subprocess.run(
["ffmpeg", "-encoders"], capture_output=True, text=True, timeout=5
)
return "libfdk_aac" in result.stdout
except Exception:
return False

_LIBFDK_AAC_AVAILABLE = _check_libfdk_aac()


class Converter:
"""Base class for audio codecs."""
Expand Down Expand Up @@ -261,16 +273,17 @@ def get_quality_arg(self, _: int) -> str:


class AAC(Converter):
"""Class for libfdk_aac converter.
"""Class for AAC converter.

Uses libfdk_aac if available, falls back to the native FFmpeg aac encoder.
Default ffmpeg_arg: `-b:a 256k`.

See available options:
https://trac.ffmpeg.org/wiki/Encode/AAC
"""

codec_name = "aac"
codec_lib = "libfdk_aac"
codec_lib = "libfdk_aac" if _LIBFDK_AAC_AVAILABLE else "aac"
container = "m4a"
default_ffmpeg_arg = "-b:a 256k"

Expand Down