feat(deezer): cache album metadata to avoid redundant API calls#1000
Open
berettavexee wants to merge 2 commits into
Open
feat(deezer): cache album metadata to avoid redundant API calls#1000berettavexee wants to merge 2 commits into
berettavexee wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When downloading a Deezer album,
get_albumcan be called multiple times for the same album ID (e.g. once for the album itself, and once per track viaget_track). This PR adds an in-memory cache onDeezerClientso that repeated lookups for the same album ID return immediately without hitting the API again. This halves the number of API calls required to download an album. No changes to playlists.self._album_cache: dictinDeezerClient.__init__get_album; store the result before returningget_albumcalls on the same IDTest plan
test_deezer_album_cachepasses: verifiesget_albumcalled twice with the same ID hits the API only once🤖 Generated with Claude Code
👌 Tested by a human