Skip to content

Fix Historic-Picks write failing on integer columns sent as floats - #154

Merged
nathan-probert merged 1 commit into
mainfrom
fix/historic-picks-int-coercion
Nov 11, 2026
Merged

nathan-probert merged 1 commit into
mainfrom
fix/historic-picks-int-coercion

Conversation

@nathan-probert

Copy link
Copy Markdown
Owner

The ML pass's write_historic_picks_if_missing failed with Postgres 'invalid input syntax for type integer: "10.0"' because pandas carries integer columns (tims, opp_goalie_games_played, etc.) as float64 whenever a NaN is possible, so a value like 10.0 was serialized verbatim. Coerce integral floats to Python int before inserting. Reproduced locally against Historic-Picks-dev; write now succeeds.

@nathan-probert
nathan-probert merged commit 480c27b into main Nov 11, 2026
6 of 7 checks passed
@nathan-probert
nathan-probert deleted the fix/historic-picks-int-coercion branch November 11, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant