Remove errors from functions that return LuaType#211
Merged
natecraddock merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
These functions mapped LuaType.nil to a Zig error. When the returned type is inspected, nil is still one of the possible values, even though in the case of an error that is not possible. I think it makes more sense to not return errors for these functions.
Owner
Author
|
@robbielyman curious on what you think of this I also wonder if it would be good to make a new enum |
Collaborator
|
I'm in favor of this change, and the proposed |
Owner
Author
|
Great thanks for taking a look! I guess now I need to determine which functions can return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions mapped LuaType.nil to a Zig error. When the returned type is used, nil is still one of the possible values, even though in the case of an error that is not possible. That leads to needing to handle the "nil" case twice (once in the error union, once in the return value).
I think it makes more sense to not return errors for these functions.