Fix HDF5 variable attributes displayed as byte reprs - #372
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #372 +/- ##
===========================================
+ Coverage 96.95% 96.97% +0.02%
===========================================
Files 9 9
Lines 591 596 +5
===========================================
+ Hits 573 578 +5
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #370.
Decode HDF5 scalar attribute bytes through the shared normalizer and decode string arrays before reference handling. Fixed- and variable-length storage now compare as the same text, including multidimensional arrays, while numeric arrays and object-reference resolution retain their existing behavior.
Validation on macOS arm64, Python 3.12.11:
git diff --checkpassed. Changelog updated.Live Earthdata downloads and Windows/Linux runs were not performed. The separate list-truncation issue #371 is outside this change.
📚 Documentation preview 📚: https://ncompare--372.org.readthedocs.build/en/372/