Repository navigation
Eclipse: soft sunlight near totality, no prominences in sunlight - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Eclipse bugs, both easiest to see with a bright, high-contrast image setup.
Hard-edged sunlight before totality. Baily's beads glowed at full strength for the whole partial phase, summed over the entire crescent rather than just thin gaps in the limb. That swelled the sunlight into a lumpy blob with a crisp rim. Beads now glow only where the limb leaves a thin gap, and only in the last moments before and after totality. The glare, diamond-ring core and bead halos also had Gaussian cores, which clip to a flat white disc with a steep edge at high brightness. They now use power-law falloffs that carry about the same light and fade gradually.
Prominences in sunlight. The chromosphere and prominences kept a 10% floor, so they showed around the uncovered sun. They now stay at zero until only about 1% of the sun is left, then fade in toward totality.
This isn't a recent regression: a v0.3.0 build renders these moments the same way.
Screenshots
Before (top) and after (bottom), crops round the sun, rendered with a bright custom look (brightness 1.74, contrast 1.35, bloom 1.14), 4.76-minute cycle.
Approaching totality, at t = 20, 50, 56 and 57.5 s:
Early partial phase (t = 1 s): the pink prominence at the lower cusp is gone.
Verified
swift build -c release, and the shader compiles:--snapshot --defaults --scene eclipse --time 300renders.--benchmark --defaults --scene eclipse: about 2.0 ms frame GPU time.Not done: README media isn't re-rendered. The changes mostly affect the moments around totality.