Fix: Opaque, instead of translucent, sticky version banner#1035
Merged
Conversation
github-actions
Bot
added
the
documentation
melissawm
approved these changes
Jun 4, 2026
Member
|
Merging as an urgent usability fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Follow-up to napari/napari-sphinx-theme#228
Description
The version banner had some transparency (see screenshots), likely as a hack to make the button more prominent. This modifies the css to blend with a theme-appropriate color (namely
napari-grayfor light, andnapari-dark-grayfor dark) so that there is no longer transparency. This mostly matches what we saw before.Top is current, bottom is this PR:
Note: I actually like the transparent banner because I feel like it makes it more noticeable, but for it to look intentional we would also want transparency on the navbar.
Note 2: We should also consider having our own theme color set in napari-sphinx-theme for the banner, because this is inheriting from pydata-sphinx-theme colors. I just wanted to mention. It's also potentially a good thing that it's quite noticeably a different color from the theme, but still vaguely matches the palette -- I think that makes it stand out more.