Skip to content

Add initializer and initargs#232

Draft
gwerbin wants to merge 1 commit into
nalepae:masterfrom
gwerbin:add-initargs
Draft

Add initializer and initargs#232
gwerbin wants to merge 1 commit into
nalepae:masterfrom
gwerbin:add-initargs

Conversation

@gwerbin

@gwerbin gwerbin commented Apr 18, 2023

Copy link
Copy Markdown

Here is an initial draft implementation of #231.

Still to-do:

  • New documentation
  • Test cases
  • Type hints

I also see a lot of missing argument and return type hints across the codebase. I can add some of those while I am working on this PR, if that's OK.

Initial draft implementation of nalepae#231
@codecov

codecov Bot commented Apr 18, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.72%. Comparing base (b78c63c) to head (e745151).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   91.37%   86.72%   -4.66%     
==========================================
  Files          12       12              
  Lines         580      580              
==========================================
- Hits          530      503      -27     
- Misses         50       77      +27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant