Fewer ByteString allocations in CPS parser with ByteStringIdx - #46
Merged
mzabani merged 12 commits intoAug 24, 2026
Conversation
ByteStringIdx
It's only used to fetch field values, and values with length exactly 0 are extremely rare
mzabani
force-pushed
the
cps-parser-fewer-bytestrings
branch
from
August 23, 2026 13:29
e9d01e1 to
253fbd7
Compare
And delete a test that became unnecessary
mzabani
marked this pull request as ready for review
August 23, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of performance optimizations
Compared to
master:From the GHC Core, the main difference here is that in row decoders, parser continuations don't require allocating new
ByteStrings, justInts (ByteStringIdx). I don't expect this made a difference here, but it will be useful for future optimizations.What this also does is push the part of the code that converts
ByteString -> [a](whereais the user's target row type) down in a way that we can avoid creating one instance ofByteStringper row, and instead pass a big chunk of rows as the same singleByteString, and further down we canparseManydirectly from that to[a].