Skip to content

fix: use single quotes in SQL query to support ANSI_QUOTES mode #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prathamesh04 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use single quotes in SQL query to support ANSI_QUOTES mode #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gui/backend/gui_plugin/core/dbms/DbMySQLSessionSetupTasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ def on_connected(self):
result = self.execute("""
SELECT ROUTINE_NAME
FROM information_schema.routines
WHERE ROUTINE_SCHEMA="sys"
AND ROUTINE_NAME="mle_explain_error"
AND ROUTINE_TYPE="PROCEDURE"
WHERE ROUTINE_SCHEMA='sys'
AND ROUTINE_NAME='mle_explain_error'
AND ROUTINE_TYPE='PROCEDURE'
""").fetch_all()
self.define_data(common.MySQLData.HAS_EXPLAIN_ERROR, len(result) > 0)

Expand Down
2 changes: 1 addition & 1 deletion gui/backend/gui_plugin/core/dbms/DbSession.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def terminate_thread(self):
self._close_database(True)
if self.thread_error is not None:
logger.error(f"Thread {self._id} exiting with code {self.thread_error}")
self._message_callback("ERROR", self.thread_error)
self._message_callback("ERROR", self.thread_error, None)
self._term_complete.set()

def execute_thread(self, sql, params, options=None):
Expand Down