Skip to content

fix(links): prevent spam link submissions and handle React keys corre… #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Strategosky wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(links): prevent spam link submissions and handle React keys corre… #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions src/components/LinksComponent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ function ContributeModal({ isOpen, onClose, onSubmit }) {
return
}

if (
title.trim().toLowerCase() === 'q' ||
title.trim().toLowerCase() === 'test'
) {
setSubmitError('Please enter a valid, descriptive title')
return
}

const validLinks = links.filter(
(link) => link.url.trim() && link.description.trim()
)
Expand Down Expand Up @@ -173,7 +181,17 @@ export function LinksComponent() {
.orderBy('createdate', 'desc')
.get()
console.log(response)
const data = response.docs.map((doc) => doc.data())
const data = response.docs
.map((doc) => ({
id: doc.id,
...doc.data(),
}))
.filter(
(item) =>
item.title &&
item.title.trim().toLowerCase() !== 'q' &&
item.title.trim().toLowerCase() !== 'test'
)
setOtherlinks(data)
setLoading(false)
} catch (error) {
Expand Down Expand Up @@ -251,7 +269,17 @@ export function LinksComponent() {
.collection('otherlinks')
.orderBy('createdate', 'desc')
.get()
const newData = response.docs.map((doc) => doc.data())
const newData = response.docs
.map((doc) => ({
id: doc.id,
...doc.data(),
}))
.filter(
(item) =>
item.title &&
item.title.trim().toLowerCase() !== 'q' &&
item.title.trim().toLowerCase() !== 'test'
)
setOtherlinks(newData)
} catch (err) {
console.error('Error submitting links:', err)
Expand Down