Skip to content

U iconsistency#271

Merged
lwinmoepaing merged 2 commits intomyanmar-software-engineers:mainfrom
kaungmyatshwe1397:UIconsistency
Mar 27, 2026
Merged

U iconsistency#271
lwinmoepaing merged 2 commits intomyanmar-software-engineers:mainfrom
kaungmyatshwe1397:UIconsistency

Conversation

@kaungmyatshwe1397
Copy link
Copy Markdown
Contributor

feat(books-classes): refactor pages, unify hero UI, and add Books/Classes contribution docs

Summary

Refactors Books and Classes sections to match the design system .Split styling components from logic code to make it more easily manageable and add shared header section under component folder while fixing the bug of description and header text not changing from English to Myanmar.


What Changed

Make logic and styling in different files

  • src/app/books/page.tsx + BooksPageClient.tsx
  • src/app/classes/page.tsx+ClasssesPageClient.tsx
  • src/components/common/sectionHero/sectionHero.tsx (For shared headersection for those components)
  • Header content title,description show correctly now when toggled en and mm.
  • Add floating icon badge

Contributor docs

  • README.md — added Add Your Book and Add Your Class sections, inserted between Add Your Profile and Project Structure

Why

  • Visual consistency across all platform sections
  • Route files stay focused on data/metadata; UI lives in dedicated client components
  • SectionHero reduces duplication and makes future hero changes a one-file edit
  • Bilingual support now works in Books and Classes, not just existing sections
  • Clearer onboarding for new contributors submitting Books/Classes content

Validation

bun run build   # ✅ succeeded locally

Checklist

  • Build passes (bun run build)
  • No errors in updated UI files
  • EN/MM strings added for new hero sections
  • README contribution guide updated
  • No new product features introduced (refactor/docs only)

Before

Screen.Recording.2026-03-25.161746.mp4

After

Screen.Recording.2026-03-25.161919.mp4
  • Update of README.md
Screenshot 2026-03-25 163558
<img width="1920" height="1020" alt="Screenshot 2026-03-25 163611" src="https://github.com/user-attachments/assets/140f1233-f516-4fd8-9f43-320a02ec8e56" />

Copy link
Copy Markdown
Member

@lwinmoepaing lwinmoepaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@lwinmoepaing lwinmoepaing merged commit 9fb05b6 into myanmar-software-engineers:main Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants