U iconsistency#271
Merged
lwinmoepaing merged 2 commits intomyanmar-software-engineers:mainfrom Mar 27, 2026
Merged
Conversation
4 tasks
9fb05b6
into
myanmar-software-engineers:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(books-classes): refactor pages, unify hero UI, and add Books/Classes contribution docs
Summary
Refactors Books and Classes sections to match the design system .Split styling components from logic code to make it more easily manageable and add shared header section under component folder while fixing the bug of description and header text not changing from English to Myanmar.
What Changed
Make logic and styling in different files
src/app/books/page.tsx + BooksPageClient.tsxsrc/app/classes/page.tsx+ClasssesPageClient.tsxsrc/components/common/sectionHero/sectionHero.tsx(For shared headersection for those components)Contributor docs
README.md— added Add Your Book and Add Your Class sections, inserted between Add Your Profile and Project StructureWhy
SectionHeroreduces duplication and makes future hero changes a one-file editValidation
bun run build # ✅ succeeded locallyChecklist
bun run build)Before
Screen.Recording.2026-03-25.161746.mp4
After
Screen.Recording.2026-03-25.161919.mp4