-
Notifications
You must be signed in to change notification settings - Fork 1
docs: added an ADR for folder structure #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+60
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Title | ||
|
|
||
| Folder structure | ||
|
|
||
| ## Date proposed | ||
|
|
||
| 05-14-2026 | ||
|
|
||
| ## Context | ||
|
|
||
| With our current repository structure we have the following cons: | ||
|
|
||
| 1. You must understand the language and framework to be able to find things | ||
| 1. You must dig through multiple folders to be able to get a grasp of what a single domain does | ||
| 1. It isn't obvious what works together without looking through code | ||
|
|
||
| ## Decision | ||
|
|
||
| We will follow screaming architecture. Our folder structure will look something like the following: | ||
|
|
||
| ``` | ||
| src/ | ||
| ├── Institutions/ | ||
| │ ├── Institution/ | ||
| │ │ ├── api.test.ts | ||
| │ │ ├── api.ts | ||
| │ │ ├── api.test.ts | ||
| │ │ └── Institution.tsx | ||
| │ ├── api.test.ts | ||
| │ ├── api.ts | ||
| │ ├── Institutions.test.ts | ||
| │ └── Institutions.tsx | ||
| ├── Member/ | ||
| │ ├── api.test.ts | ||
| │ ├── api.ts | ||
| │ ├── Member.test.ts | ||
| │ └── Member.tsx | ||
| └── shared/ | ||
| │ ├── Member/ | ||
| │ │ ├── api.test.ts | ||
| │ │ ├── api.ts | ||
| │ │ ├── consts.ts | ||
| │ │ ├── utils.test.ts | ||
| │ │ └── utils.ts | ||
| │ └── Validation/ | ||
| │ ├── date.test.ts | ||
| │ ├── date.ts | ||
| │ ├── required.ts | ||
| │ └── required.ts | ||
| ├── vite.config.ts | ||
| └── App.tsx | ||
| ``` | ||
|
|
||
| All folders underneath src and shared are domains. Things stay in their domain underneath src until they are actually shared, then they can move to the shared folder. Files that are used together stay in close proximity. | ||
|
|
||
| ## Consequences | ||
|
|
||
| 1. It will be easier to find things | ||
| 1. It will be easier to understand how related things work together | ||
| 1. Our folders will have a clear structure to be followed | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.