Skip to content

added commands state#89

Closed
igorkorsukov wants to merge 1 commit into
musescore:mainfrom
igorkorsukov:w/rcmd/rcmd_step4
Closed

added commands state#89
igorkorsukov wants to merge 1 commit into
musescore:mainfrom
igorkorsukov:w/rcmd/rcmd_step4

Conversation

@igorkorsukov

@igorkorsukov igorkorsukov commented Jun 17, 2026

Copy link
Copy Markdown
Member

Key points:

  • Like with the register, there is a single interface for obtaining the state of any command; it uses the states of specific modules.
  • The implementation of calculating the states of specific commands is located in the module that processes these commands.
  • We need to manage all state changes ourselves to notify about state changes. (For simplicity, we can think of this as the availability of menu items, although in reality it's not directly related to menus.)
  • I added constants for the commands there, and I'm still confused by this decision, since it will lead to one module being dependent on another... But in our case, they are already linked at the compiler level; the main thing is not to link them at the link level.

@igorkorsukov

Copy link
Copy Markdown
Member Author

replaced by #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant