Skip to content

[uicomponents] omit table separators that double the container border#88

Open
luapmartin wants to merge 1 commit into
musescore:mainfrom
luapmartin:luapmartin/table-separator-fix
Open

[uicomponents] omit table separators that double the container border#88
luapmartin wants to merge 1 commit into
musescore:mainfrom
luapmartin:luapmartin/table-separator-fix

Conversation

@luapmartin

Copy link
Copy Markdown
Contributor

The last column's right separator and the last row's bottom separator sat on top of the table's 1px container border, giving those edges a doubled, thicker look. Hide them when the content fills that dimension (so the edge coincides with the border); keep them otherwise, so a table with empty space below/right still delimits its last row/column.

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

The last column's right separator and the last row's bottom separator sat on
top of the table's 1px container border, giving those edges a doubled, thicker
look. Hide them when the content fills that dimension (so the edge coincides
with the border); keep them otherwise, so a table with empty space below/right
still delimits its last row/column.
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9cb9d08b-87e0-4ec7-a8a9-fbd93fbb4dc0

📥 Commits

Reviewing files that changed from the base of the PR and between 1fe009b and c5d00da.

📒 Files selected for processing (3)
  • framework/uicomponents/qml/Muse/UiComponents/StyledTableView.qml
  • framework/uicomponents/qml/Muse/UiComponents/internal/StyledTableViewCell.qml
  • framework/uicomponents/qml/Muse/UiComponents/internal/StyledTableViewColumn.qml

📝 Walkthrough

Walkthrough

The changes add conditional separator visibility logic to the StyledTableView component family. A new showTrailingSeparator boolean property is introduced on StyledTableViewColumn, with its trailing SeparatorLine now bound to that property. In StyledTableView, this property is set on header columns based on whether the table's content width fills the viewport. In StyledTableViewCell, visible conditions are added to suppress the bottom separator on the last row and the right separator on the last column, each only when the corresponding content dimension (height or width) meets or exceeds the viewport dimension.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the primary change: omitting table separators that duplicate the container border.
Description check ✅ Passed The description explains the problem and solution clearly, includes a completed contributor checklist, and specifies build configurations as required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant