[4.7.4] Add stave and MPE support for East Asian instruments#33834
Open
RomanPudashkin wants to merge 2 commits into
Open
[4.7.4] Add stave and MPE support for East Asian instruments#33834RomanPudashkin wants to merge 2 commits into
RomanPudashkin wants to merge 2 commits into
Conversation
Added instruments: - China: Guqin, Pipa, Yangqin - Japan: Hichiriki, Sho - Korea (melodic): Ajaeng, Daegeum, Gayageum - Korea (percussion): Samul Buk, Samul Janggu, Sanjo Janggu, Sori Buk
Contributor
|
Tested and approved @shoogle the instruments spreadsheet will need to be updated to include this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added instruments:
MPE IDs:
Guqin - strings.guqin.chinese:plucked
Pipa - strings.pipa.chinese:plucked
Yangqin - strings.yangqin.chinese
Gayageum - strings.gayageum.korean:plucked
Ajaeng - strings.ajaeng.korean
Daegeum - winds.daegeum.korean
Hichiriki - winds.hichiriki.japanese
Sho - winds.sho.japanese
Samul Buk - percussions.samul_buk.korean
Samul Janggu - percussions.samul_janggu.korean
Sanjo Janggu - percussions.sanjo_janggu.korean
Sori Buk - percussions.sori_buk.korean
Shamisen - strings.shamisen.japanese:plucked
Shoko - percussions.shoko