Make int input validator locale aware [4.7.4 port]

[mathesoncalum]

Ports: musescore/muse_framework#64
Ports: musescore/muse_framework#91
Resolves: #33698

[mathesoncalum]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR refactors IntInputValidator to use Qt's QLocale API for numeric parsing and formatting instead of plain QString conversions. The fixup() method now parses values through QLocale::toInt, defaults invalid parses to locale-formatted zero, and clamps results to configured bounds. The validate() method strips locale group separators before parsing and uses QLocale::toInt with an ok flag to determine acceptability and intermediate states. Comprehensive test coverage is added for both plain (en_US) and grouped/decimal (de_DE) locales, with test registration in the build configuration.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	PR description is minimal and lacks required template sections like motivation, CLA signature, commit message verification, code compilation confirmation, testing details, and change justification.	Complete the pull request description template: add detailed motivation for the changes, confirm CLA signature, verify commit messages reference the issue, confirm code compiles and tests pass, and explain all changes follow coding rules.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The code changes successfully address issue #33698 by fixing locale-aware number parsing in IntInputValidator, re-enabling tests, and ensuring DPI values are properly retained.
Out of Scope Changes check	✅ Passed	All changes are scope-aligned: CMakeLists update adds test source file, intinputvalidator_tests.cpp adds comprehensive unit tests, and intinputvalidator.cpp fixes locale-aware string parsing logic per issue #33698.
Title check	✅ Passed	The title accurately summarizes the main change: making the IntInputValidator locale-aware, which directly addresses the core fix in the changeset and resolves the locale-related parsing issue in the linked issue #33698.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}