🐛 End RL episodes at the hard pass horizon - #801
Draft
flowerthrower wants to merge 2 commits into
Draft
flowerthrower wants to merge 2 commits into
flowerthrower wants to merge 2 commits into
Conversation
Assisted-by: GPT-5.6 via Codex Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
Assisted-by: GPT-5.6 via Codex Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Treat exhaustion of
PredictorEnv.max_stepsas a terminal outcome rather thana time-limit truncation.
Stable-Baselines3 bootstraps Gymnasium truncations with the critic value of the
terminal observation. The configured pass limit is the hard compilation and
deployment horizon, so continuation beyond it is unreachable. This change
retains the zero reward but returns
terminated=Trueandtruncated=Falsewhena non-termination action consumes the final slot. Pass failures remain
truncations.
AI assistance was used to inspect the environment and Stable-Baselines3 rollout
semantics and to prepare this focused patch.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).