Skip to content

✨ Add missing TKET RL actions - #796

Open
flowerthrower wants to merge 2 commits into
v3/paper-bqskit-passesfrom
v3/paper-tket-passes
Open

flowerthrower wants to merge 2 commits into
v3/paper-bqskit-passesfrom
v3/paper-tket-passes

Conversation

@flowerthrower

@flowerthrower flowerthrower commented Aug 27, 2026

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Description

Adds the TKET actions used by the paper prototype but missing from the production registry: KAKDecomposition, GraphPlacement, and NoiseAwarePlacement.

The placement actions translate TKET placement maps into complete Qiskit layouts through the existing layout pipeline. NoiseAwarePlacement receives mean one- and two-qubit gate errors per node and link, while measurement errors are excluded from those averages and supplied separately as readout errors. Registered TKET layout actions must provide exactly one Placement.

TKET layout and routing actions are masked for circuits containing operations wider than two qubits.

Focused tests cover calibration aggregation, wide-operation masking, real graph and noise-aware placement, KAK semantics, and the public placement boundary. Adjacent layout and registration tests and the lint suite pass.

Existing RL models must be retrained because the action schema changes.

This is position 5 of the stack. It depends on #795 and is followed by #797. No new package dependencies are introduced.

Part of #664

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@flowerthrower flowerthrower added enhancement New feature or request major Part of a major release labels Aug 27, 2026
@flowerthrower flowerthrower self-assigned this Aug 27, 2026
@flowerthrower
flowerthrower force-pushed the v3/paper-bqskit-passes branch 2 times, most recently from 8e325e1 to bb3ce81 Compare August 27, 2026 15:02
@flowerthrower
flowerthrower force-pushed the v3/paper-tket-passes branch 2 times, most recently from 1ce6b4f to 65c9d98 Compare August 27, 2026 15:07
@flowerthrower
flowerthrower marked this pull request as ready for review August 27, 2026 15:07
@flowerthrower

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 50 minutes.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 50 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1f2a73f6-8554-4a13-9283-d765cde6befd

📥 Commits

Reviewing files that changed from the base of the PR and between bb3ce81 and 65c9d98.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • UPGRADING.md
  • src/mqt/predictor/rl/actions/registry.py
  • src/mqt/predictor/rl/actions/tket_actions.py
  • src/mqt/predictor/rl/predictorenv.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com>
Assisted-by: GPT 5.6 via Codex
Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com>
Assisted-by: GPT 5.6 via Codex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request major Part of a major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant