Skip to content

馃悰 Make RL circuit sampling reproducible - #787

Closed
flowerthrower wants to merge 1 commit into
v3/paper-tket-passesfrom
v3/reproducible-rl-seeding
Closed

flowerthrower wants to merge 1 commit into
v3/paper-tket-passesfrom
v3/reproducible-rl-seeding

Conversation

@flowerthrower

@flowerthrower flowerthrower commented Aug 27, 2026

Copy link
Copy Markdown
Member

馃 AI text below 馃

Description

Makes RL training-circuit sampling honor Gymnasium's seed lifecycle.

PredictorEnv now uses Gymnasium's np_random, so reset(seed=...) controls sampling, and candidate QASM paths are sorted before indexed selection to make identical seeds reproducible across filesystems.

This draft is stacked on the TKET pass PR. It does not change BQSKit's established fixed pass seed or unrelated ML estimators. Validated with repository lint and focused sampling smoke checks.

Part of #664

Checklist

  • The diff is focused and reuses Gymnasium's RNG.
  • Lint passes.
  • I confirm that I have personally reviewed and understood all AI-generated content.

If PR contains AI-assisted content:

  • AI assistance was authorized and is disclosed.
  • This body begins with the required visible disclosure.

@flowerthrower
flowerthrower force-pushed the v3/reproducible-rl-seeding branch from 9c416ed to 4bea5f8 Compare August 27, 2026 13:21
Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com>
Assisted-by: GPT 5.6 via Codex
@flowerthrower
flowerthrower force-pushed the v3/reproducible-rl-seeding branch from 561bba3 to c55cdda Compare August 27, 2026 13:28
@flowerthrower flowerthrower added major Part of a major release fix Fix for something that is not working labels Aug 27, 2026
@flowerthrower flowerthrower self-assigned this Aug 27, 2026
@flowerthrower

Copy link
Copy Markdown
Member Author

馃 AI text below 馃\n\nSuperseded while rebuilding the corrected downstream stack after #758.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix for something that is not working major Part of a major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant