🐛 Return QDMI and benchmark errors before MLIR - #2545
Open
burgholzer wants to merge 2 commits into
Open
burgholzer wants to merge 2 commits into
burgholzer wants to merge 2 commits into
Conversation
burgholzer
added
fix
burgholzer
force-pushed
the
codex/fix-mlir-exception-boundaries
branch
from
September 12, 2026 11:05
18f186e to
e95a1ee
Compare
burgholzer
force-pushed
the
codex/fix-mlir-exception-boundaries
branch
from
September 12, 2026 11:55
c5bdf1b to
46025a6
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
burgholzer
changed the title
burgholzer
force-pushed
the
codex/fix-mlir-exception-boundaries
branch
2 times, most recently
from
September 12, 2026 12:59
f410460 to
bb0ae82
Compare
10 tasks
Decode QDMI properties as values or diagnostics and reuse that decoder in both C++ interfaces. Convert remaining client and benchmark exceptions inside their owning libraries, before returning to MLIR. Keep the adapter, benchmark generator, and CLI free of exceptions and RTTI. Remove platform flags and the split CLI entry point. Preserve existing throwing C++ APIs and require invalid CLI input to return a diagnostic with exit status 1. Assisted-by: GPT-6 via Codex
Exercise device, site, operation, and site-calibration failures through the existing sessionless provider. Require compiler diagnostics and successful recovery after restoring the provider. Assisted-by: Codex
burgholzer
force-pushed
the
codex/fix-mlir-exception-boundaries
branch
from
September 14, 2026 18:08
bb0ae82 to
f7553f5
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Return QDMI and benchmark diagnostics before entering RTTI-free MLIR code. The shared QDMI decoder supports both value/error and existing throwing interfaces; the owning C++ libraries catch the remaining device and JSON exceptions. The adapter, generator, and CLI no longer need exception/RTTI overrides or a split entry point.
Preserve CLI diagnostics, UTF-8 paths, and existing output files on failure. Tests cover provider query failures, normalized benchmark metadata, and exit status 1. This PR owns these fixes; release optimization remains in #2476, stacked on this branch.
Validation: local release with IPO disabled passed 3,548 C++ tests with one expected skip. Whole-file C++ lint and repository lint passed. Hosted C++/Python tests, documentation, coverage, and lint pass on this head.
AI assistance: implemented and checked with Codex.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).