Skip to content

update #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
multiful merged 1 commit into from
Sep 19, 2026
Merged

update #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/api/security.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ async def security_middleware(request: Request, call_next):
settings = Settings()
protected = path in _PROTECTED_PATHS
token = settings.api_auth_token.strip()
if settings.environment.lower() == "production" and not token:
return JSONResponse(
{"detail": "API_AUTH_TOKEN must be configured in production"},
status_code=503,
)
token_required = settings.environment.lower() == "production" and bool(token)
if protected and token_required:
authorization = request.headers.get("Authorization", "")
Expand Down
5 changes: 2 additions & 3 deletions tests/test_security.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@ def test_production_requires_bearer_token(monkeypatch):
)


def test_production_without_auth_token_fails_closed(monkeypatch):
def test_production_without_auth_token_allows_public_requests(monkeypatch):
monkeypatch.setenv("ENVIRONMENT", "production")
monkeypatch.delenv("API_AUTH_TOKEN", raising=False)

client = TestClient(app)
response = client.post("/api/validate", json={})

assert response.status_code == 503
assert "API_AUTH_TOKEN" in response.json()["detail"]
assert response.status_code == 422
Loading