Build/Test Tools: Bound the supported Node version range - #76
Draft
mukeshpanchal27 wants to merge 1 commit into
Draft
Build/Test Tools: Bound the supported Node version range#76mukeshpanchal27 wants to merge 1 commit into
mukeshpanchal27 wants to merge 1 commit into
Conversation
See the PR description for the full rationale and evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Node version a contributor may install is unbounded, while CI is pinned:
package.jsonengines.node>=20.10.0.nvmrc20.npmrcengine-strict = truenode-version-file: '.nvmrc'A contributor on Node 22 or 24 passes the strict engine gate and develops happily, while
all CI runs Node 20. Any newer-Node behavior difference surfaces only in CI, after push.
Change
Bounds the range to
>=20.10.0 <21so local and CI agree.This is a policy proposal, not a bug fix
With
engine-strict = true, this blocks installs on Node 21+. That is the point — itmakes the mismatch a local error rather than a CI surprise — but it is a real constraint on
contributors who currently use newer Node successfully. The alternative is to widen
.nvmrcand the CI matrix instead. Opening as a draft specifically to get a decision on which
direction is wanted.
Draft proposal from a review of
composer.json/package.json. Opened as a draft for discussion — not intended to merge as-is.