Build/Test Tools: Pin remaining ranged devDependencies to exact versions - #75
Draft
mukeshpanchal27 wants to merge 1 commit into
Draft
Build/Test Tools: Pin remaining ranged devDependencies to exact versions#75mukeshpanchal27 wants to merge 1 commit into
mukeshpanchal27 wants to merge 1 commit into
Conversation
See the PR description for the full rationale and evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.npmrcsetssave-exact = true, but 15devDependenciesstill carry^or~ranges.They predate that policy.
package-lock.jsonis committed, so installs are reproducible today and nothing is broken.The practical effect is that
npm updatemoves these 15 silently while every otherdependency stays frozen — an inconsistency that will surprise whoever runs it.
Change
Pins all 15 to exact versions.
No lockfile churn
Every one of these currently resolves to the floor of its own range, verified against
package-lock.json:@lodder/grunt-postcss^3.1.13.1.13.1.1grunt-banner^0.6.00.6.00.6.0grunt-contrib-clean~2.0.12.0.12.0.1grunt-contrib-copy~1.0.01.0.01.0.0grunt-contrib-cssmin~5.0.05.0.05.0.0grunt-contrib-imagemin~4.0.04.0.04.0.0grunt-contrib-uglify~5.2.25.2.25.2.2grunt-contrib-watch~1.1.01.1.01.1.0grunt-legacy-util^2.0.22.0.22.0.2grunt-patch-wordpress~4.0.04.0.04.0.0grunt-replace-lts~1.1.01.1.01.1.0grunt-rtlcss~2.0.22.0.22.0.2grunt-sass~4.1.04.1.04.1.0qunit~2.26.02.26.02.26.0sinon-test~3.1.63.1.63.1.6So
package-lock.jsonis unchanged by this PR — the pins describe what is already installed.Draft proposal from a review of
composer.json/package.json. Opened as a draft for discussion — not intended to merge as-is.