Build/Test Tools: Declare dealerdirect/phpcodesniffer-composer-installer explicitly - #72
Draft
mukeshpanchal27 wants to merge 1 commit into
Draft
Build/Test Tools: Declare dealerdirect/phpcodesniffer-composer-installer explicitly#72mukeshpanchal27 wants to merge 1 commit into
mukeshpanchal27 wants to merge 1 commit into
Conversation
…ler explicitly See the PR description for the full rationale and evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dealerdirect/phpcodesniffer-composer-installeris listed inconfig.allow-plugins,but is not in
require-dev. It arrives transitively viawp-coding-standards/wpcsandphpcompatibility/phpcompatibility-wp.That plugin is what populates the PHP_CodeSniffer
installed_pathssetting — i.e. whethercomposer lintcan resolve theWordPressstandard at all depends on a package nobodydeclared. The project already explicitly trusts it in
allow-plugins, so the dependencyis deliberate; only the declaration is missing.
Change
Adds the explicit
require-deventry so the tool that makes linting work is visible.Draft proposal from a review of
composer.json/package.json. Opened as a draft for discussion — not intended to merge as-is.