refactor(design): move cross-tool wireframe conventions into Designer Denise - #48
Merged
Merged
Conversation
… Denise Retire the workspace-level ~/dev/WIREFRAMES.md as the cross-tool source of truth and give Designer Denise ownership. The tool-agnostic canvas principles (axes, no-overlap, tight canvas, sticky notes, the NEW NEW marker + demotion sweep, LEGEND) now live in the design pack at design/references/wireframes-cross-tool.md. - New: design/references/wireframes-cross-tool.md (tool-agnostic principles). - pencil-mockup/references/wireframes.md stays the Pencil-specific superset; its precedence drops the workspace-override tier (now project spec/WIREFRAMES.md -> this file) and points at the cross-tool sibling for non-Pencil tools. - Repointed design README, shared/core.md, pencil-mockup SKILL, style-guide SKILL off the ~/dev/WIREFRAMES.md path. - Repointed the qa plugin's 5 citations (README, shared/core.md, browser SKILL, happy-path-extraction, qa-plan SKILL) and refreshed a stale gate-script comment. - design plugin 1.2.0 -> 1.3.0 with a pencil-mockup CHANGELOG entry. The matching removal of ~/dev/WIREFRAMES.md and the ~/dev/CLAUDE.md pointer repoint land in a separate ~/dev PR (the CLAUDE.md edit is behind the approval gate). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe PR adds shared cross-tool wireframe rules, removes workspace-level precedence, updates design and QA references, and releases the design plugin as version 1.3.0. ChangesWireframe convention update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@design/references/wireframes-cross-tool.md`:
- Around line 27-29: Resolve the contradictory touching-edge guidance in the
layout contract by stating a single rule for frames with visible strokes and
frameless frames. Update the opening overlap rule and the subsequent principle
consistently so the same geometry always has one defined outcome.
In `@design/shared/core.md`:
- Line 18: Update the source-of-truth guidance in the referenced design
documentation by removing the duplicated “load-bearing points” summary following
the instruction to read wireframes.md. Keep wireframes.md authoritative and
retain only the runtime-loading and project-level precedence guidance.
In `@design/skills/pencil-mockup/CHANGELOG.md`:
- Around line 3-5: Update the v1.3.0 changelog entry to clarify that Denise’s
precedence chain no longer uses ~/dev/WIREFRAMES.md, without claiming the
workspace file itself was removed; state that its removal is pending if needed.
In `@design/skills/pencil-mockup/references/wireframes.md`:
- Around line 8-10: Update the Pencil reference in wireframes.md so it does not
tell Pencil work to ignore wireframes-cross-tool.md; instead, make the shared
cross-tool file authoritative and keep only Pencil-specific rules in this file.
Use the existing wireframes.md and ../../../references/wireframes-cross-tool.md
symbols as the source of truth relationship, and either remove the copied shared
guidance here or add a drift check that keeps both references aligned.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 269005a9-62bf-4517-b89e-49315e1cb430
📒 Files selected for processing (14)
design/.claude-plugin/plugin.jsondesign/README.mddesign/references/wireframes-cross-tool.mddesign/shared/core.mddesign/skills/pencil-mockup/CHANGELOG.mddesign/skills/pencil-mockup/SKILL.mddesign/skills/pencil-mockup/references/wireframes.mddesign/skills/style-guide/SKILL.mdqa/README.mdqa/hooks/scripts/qa-status-gate.shqa/shared/core.mdqa/skills/browser/SKILL.mdqa/skills/browser/references/happy-path-extraction.mdqa/skills/qa-plan/SKILL.md
…move Four findings from the PR #48 review, all valid: - Resolve the self-contradicting overlap rule. It said edges touching is fine, then said touching counts as overlap with visible strokes, giving the same geometry two outcomes. Now: never overlap, touch only when neither frame renders a stroke. - Stop the CHANGELOG claiming ~/dev/WIREFRAMES.md "was retired". The companion ~/dev PR that deletes it is still open, so the file is on disk; this release only drops it from Denise's precedence chain. The false-completion claim had already misled a later session into nearly deleting the only remaining copy. - Label core.md's bullets a non-authoritative checklist instead of telling readers not to paraphrase and then paraphrasing. - Make the cross-tool reference authoritative for shared principles rather than telling Pencil work to ignore it. The original self-contained rationale came from PR #28, when the shared file lived outside the plugin; both files now ship in the design plugin, so a reference between them always resolves and the duplication no longer buys portability. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011GsGa24cyrLQ85FswVAiBX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the tool-agnostic wireframe conventions out of the workspace-level
~/dev/WIREFRAMES.mdand into the Designer Denise design plugin, so Denise owns them. Sidequest handoff from a separate session.New home
design/references/wireframes-cross-tool.md(new): tool-agnostic canvas principles (layout axes, no-overlap hard error, tight canvas, sticky-note annotations, the🚧 NEW NEWmarker + post-deploy demotion sweep, LEGEND). Canonical cross-tool source of truth any future non-Pencil tool (Figma, tldraw, Balsamiq) reads.pencil-mockup/references/wireframes.mdstays the Pencil-specific superset; precedence dropped the now-gone workspace-override tier (nowproject spec/WIREFRAMES.md-> this file) with a pointer to the cross-tool sibling.Repointed off
~/dev/WIREFRAMES.mdREADME.md,shared/core.md,pencil-mockup/SKILL.md,style-guide/SKILL.md.README.md,shared/core.md,browser/SKILL.md,browser/references/happy-path-extraction.md,qa-plan/SKILL.md(attribution repoints; qa only used the axis one-liner it already states inline). Plus a refreshed stale comment inqa-status-gate.sh.designplugin1.2.0 -> 1.3.0+ pencil-mockup CHANGELOG entry. No qa version bump (pure doc-citation repoint).Companion PR
mujtaba3B/dev#77deletes~/dev/WIREFRAMES.mdand repoints its README. Merge this PR first, then #77 (this one repoints the plugins off the workspace file; the reference is an optional override so order is not load-bearing).QA
📄 Plan view: https://claude.ai/code/artifact/1d970a4e-4669-4483-bde5-c4df63de292a (rendered companion; this section stays the source of truth)
QA driver: Claude (the building agent (this session)) - the whole flow is a local
bin/installplus filesystem assertions, fully automatable, and this session can drive it and record evidence now.Standard (all green): unit tests · lint/types · CI ·
/eng:cr🖥️ Development
Before merging, we refresh the copy of the plugin that Claude actually runs from and prove the new conventions file is really in there, because merging alone does not update it.
bin/installto refresh the plugin cachedesign1.3.0 appears in the cache~/.claude/plugins/cache/gstack-extensions/, never the repo. Cache held 1.2.0 before this..../design/1.3.0/references/wireframes-cross-tool.mdexistsdesign/1.3.0+qa/3.6.1design/1.2.0,qa/3.5.0,qa/3.6.0) that Claude no longer loads, and 1 is the deliberate historical scope note in the 1.3.0 CHANGELOG. Amended to the property that actually matters.claude plugin validate . --strict🚀 Production
After the companion PR deletes the old workspace file, we re-run the same check, because that deletion is what turns a leftover citation from harmless into broken.
~/devdeletesWIREFRAMES.mdProduction artifacts:
~/.claude/plugins/cache/gstack-extensions/design/1.3.0/on the laptop (mujtabas-laptop), exercised by loading the Designer Denise skills.~/.claude/plugins/cache/gstack-extensions/qa/<installed-version>/on the same host, exercised by loading the QA Quincey skills.bin/install.Dev QA evidence (run 2026-08-05 by claude at
e1d9f81, installed from a detached checkout of the PR commit so the marketplace path stayed canonical):bin/installexit 0; cache went fromdesign 1.2.0to1.2.0 1.3.0.design/1.3.0/references/wireframes-cross-tool.mdpresent, 86 lines.designplugin explicitly, and the target exists.claude plugin validate . --strictexit 0.mainmoved qa to 3.6.1 and the branch inherited it, so the repointed qa citations did reach a fresh cache dir.Definition of Done:
bats hook suitespass; no unit-testable surface in a docs diff)/eng:cr) + CodeRabbit addressedwhere-things-run.jsonbumped if the deploy changed hosts (N/A: no host change, local plugin cache only)QA posture: Pre-merge -> state
QA_STATUS: dev_verified+EVIDENCE:once every Dev QA box and every Definition-of-Done box is checked. Post-deploy -> stateQA_STATUS: prod_verified+EVIDENCE:once the Prod QA rows are verified live.Supersedes the handbook-standard plan's "WIREFRAMES.md stays a git-tracked sibling reference spec" line (noted, not edited).
🤖 Generated with Claude Code
Summary by CodeRabbit