[icons-material] Build lib/package.json with code-infra --no-expand#48689
Open
Janpot wants to merge 1 commit into
Open
[icons-material] Build lib/package.json with code-infra --no-expand#48689Janpot wants to merge 1 commit into
Janpot wants to merge 1 commit into
Conversation
Deploy previewhttps://deploy-preview-48689--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
Janpot
added
the
scope: code-infra
brijeshb42
reviewed
Jun 18, 2026
Comment on lines
-42
to
-44
| const mergedPackageJson = { | ||
| ...rootPackageJson, | ||
| exports: wildcardExports, |
Contributor
There was a problem hiding this comment.
This script was also responsible for updating the freshly built package.json inside the build folder as per latest value in the main package.json and merged just the exports field from lib/package.json since lib/package.json doesn't change with every build.
Contributor
There was a problem hiding this comment.
This fixed a previous issue where bumping the package version didn't actually publish/bumped the new version since it was still using lib/package.json
Janpot
force-pushed
the
icons-material-drop-merge-package-json
branch
from
67733c9 to
99d947a
Compare
Janpot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code-infra build --no-expandkeeps theexportsglobs as Node subpath patterns instead of enumerating them, so the committedlib/package.jsonbecomes the small wildcard form (~16 lines) instead of ~10k explicit subpath entries that stall the TS language server (#48364).merge-package-json.mjs(build:pkg-json) is kept — it still refreshesbuild/package.jsonfrom the current rootpackage.json(notablyversion) at build time, sincelib/package.jsononly changes on icon regeneration. The published output is unchanged.Package diff