fix(MODEL-MM-QWEN4-EXP): guard ManagedAllocActive call with VLLM_CPP_HIP on non-ROCm builds - #3185
Merged
Merged
Conversation
…HIP on non-ROCm builds Commit 054546b added a call to vt::rocm::ManagedAllocActive(0) at tests/vt/test_backend_cross_device.cpp:279. The function is declared in the HIP-free header include/vt/rocm/rocm_runtime.h:57 but defined only in src/vt/rocm/rocm_backend.hip:767. On non-ROCm builds the symbol is undefined and the linker fails, breaking build-test-cpu, build-newest-gcc, build-test-vulkan, and both sanitize-cpu jobs on main. The call sits inside a for (DeviceType dt : RegisteredDevices()) loop that continues on non-kROCM devices, so the code path never executes on a non-ROCm build. Guard the call with #if defined(VLLM_CPP_HIP) and fall back to false, matching the pattern the file already uses at line 3031 for the rest of its ROCm test code. Closes #3184 FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:glm5.2 [maki]
mudler
force-pushed
the
fix/managed-alloc-active-linker
branch
from
September 13, 2026 20:55
94314e2 to
3956357
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 054546b added a call to
vt::rocm::ManagedAllocActive(0)attests/vt/test_backend_cross_device.cpp:279. The function is declared in the HIP-free headerinclude/vt/rocm/rocm_runtime.h:57but defined only insrc/vt/rocm/rocm_backend.hip:767. On non-ROCm builds the symbol is undefined and the linker fails, breakingbuild-test-cpu,build-newest-gcc,build-test-vulkan, and bothsanitize-cpujobs on main.The call sits inside a
for (DeviceType dt : RegisteredDevices())loop that continues on non-kROCMdevices, so the code path never executes on a non-ROCm build. Guard the call with#if defined(VLLM_CPP_HIP)and fall back tofalse, matching the pattern the file already uses at line 3031 for the rest of its ROCm test code.Closes #3184
FOLLOWING_AGENTS_PROTOCOL
Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: AGENT:glm5.2 [maki]