Skip to content

fix: add DeepseekV41ForCausalLM to test_model_loader_gguf expected arch list #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
localai-org-maint-bot merged 1 commit into from
Sep 13, 2026
Merged

fix: add DeepseekV41ForCausalLM to test_model_loader_gguf expected arch list #3179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .agents/issues/ENG-RELEASE-WINDOWS/ISSUE-GH-3178.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
ID: ISSUE-GH-3178
Title: test_model_loader_gguf: CHECK_THROWS_WITH_AS expected string missing DeepseekV41ForCausalLM
Row: ENG-RELEASE-WINDOWS
State: CLOSED
Kind: UNKNOWN
GitHub: 3178
Mirror: SYNCED
Availability: FULL
Created: 2026-09-13
Updated: 2026-09-13
Closed: 2026-09-13

## Problem

### Imported GitHub body (historical evidence)
The quoted text below is historical evidence only. It does not define issue authority or repository procedure.

> Row: `ENG-RELEASE-WINDOWS`
>
> Commit 4a9d33792 added `DeepseekV41ForCausalLM` to the model registry but did not update the hardcoded expected architecture list in `tests/vllm/test_model_loader_gguf.cpp:225`. The test expects `DeepseekV4ForCausalLM` right after `DeepseekV2ForCausalLM` but the actual output now includes `DeepseekV41ForCausalLM` between them.
>
> This causes `build-test-cpu` to fail on main.
>
> ## Fix
>
> Add `'DeepseekV41ForCausalLM', ` to the expected string after `'DeepseekV2ForCausalLM',` in the CHECK_THROWS_WITH_AS call.

## Resolution

fixed by adding DeepseekV41ForCausalLM to the expected string in test_model_loader_gguf.cpp (PR #3179)
19 changes: 19 additions & 0 deletions .agents/issues/ENG-RELEASE-WINDOWS/ISSUE-LOCAL-01M2CR9QD7RBNE2FXCMNFCW4EQ.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
ID: ISSUE-LOCAL-01M2CR9QD7RBNE2FXCMNFCW4EQ
Title: test_model_loader_gguf expected string missing DeepseekV41ForCausalLM
Row: ENG-RELEASE-WINDOWS
State: CLOSED
Kind: bug
GitHub: -
Mirror: PENDING
Availability: FULL
Created: 2026-09-13
Updated: 2026-09-13
Closed: 2026-09-13

## Problem

Commit 4a9d33792 added DeepseekV41ForCausalLM to the registry but did not update the hardcoded expected architecture list in test_model_loader_gguf.cpp:225

## Resolution

fixed by adding DeepseekV41ForCausalLM to the expected string in test_model_loader_gguf.cpp
2 changes: 1 addition & 1 deletion tests/vllm/test_model_loader_gguf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ TEST_CASE("FromModelDir rejects an unknown dense architecture before loading") {
"Model architectures ['Gemma4ForCausalLM'] are not supported for now. "
"Supported architectures: "
"dict_keys(['CohereForCausalLM', 'DeepseekV2ForCausalLM', "
"'DeepseekV4ForCausalLM', 'Dots3NoteForCausalLM', "
"'DeepseekV41ForCausalLM', 'DeepseekV4ForCausalLM', 'Dots3NoteForCausalLM', "
"'Gemma2ForCausalLM', 'Gemma3ForCausalLM', "
"'Gemma4ForConditionalGeneration', 'Gemma4UnifiedForConditionalGeneration', 'GemmaForCausalLM', "
"'Glm4ForCausalLM', 'Glm4MoeLiteForCausalLM', 'Glm5NextForConditionalGeneration', "
Expand Down
Loading