Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
670e6d7
spec(BACKEND-ROCM-QUANT-GATHER): define native gather coverage
VikashLoomba Sep 9, 2026
306a1be
spec(ENG-QWEN35-FULL-ATTN-STATE): scope GDN consumer checks
VikashLoomba Sep 9, 2026
44e95b3
fix(ENG-QWEN35-FULL-ATTN-STATE): skip unused GDN state checks
VikashLoomba Sep 9, 2026
4fc300f
test(ENG-QWEN35-FULL-ATTN-STATE): pin query offset guards
VikashLoomba Sep 9, 2026
376223f
spec(BACKEND-ROCM-QUANT-GATHER): admit decoder-only embedding storage
VikashLoomba Sep 9, 2026
2e5adfb
spec(BACKEND-ROCM-QUANT-GATHER): admit Q8_K file geometry
VikashLoomba Sep 9, 2026
8c9101f
spec(ENG-QWEN35-FULL-ATTN-STATE): require the runner completion regre…
VikashLoomba Sep 9, 2026
b46852d
test(ENG-QWEN35-FULL-ATTN-STATE): require runner completion without GDN
VikashLoomba Sep 9, 2026
c5bb0f1
feat(BACKEND-ROCM-QUANT-GATHER): decode packed embedding rows
VikashLoomba Sep 9, 2026
e353286
spec(BACKEND-ROCM-QUANT-GATHER): qualify bounded oracle repairs
VikashLoomba Sep 9, 2026
75d9261
fix(BACKEND-ROCM-QUANT-GATHER): qualify bounded oracle model captures
VikashLoomba Sep 9, 2026
1027200
spec(BACKEND-ROCM-QUANT-GATHER): require qualified primary reports
VikashLoomba Sep 9, 2026
92813f4
fix(BACKEND-ROCM-QUANT-GATHER): qualify generated primary reports
VikashLoomba Sep 9, 2026
fc0fae3
test(BACKEND-ROCM-QUANT-GATHER): pin every primary qualification guard
VikashLoomba Sep 10, 2026
6073e93
fix(BACKEND-ROCM-QUANT-GATHER): label the comparison scope from the run
VikashLoomba Sep 10, 2026
adaf2b7
docs(BACKEND-ROCM-QUANT-GATHER): record the original fixture coverage
VikashLoomba Sep 10, 2026
5cc915a
test(BACKEND-ROCM-QUANT-GATHER): pin the comparison report scope
VikashLoomba Sep 10, 2026
1f9107a
docs(BACKEND-ROCM-QUANT-GATHER): cite the retained review reports and…
VikashLoomba Sep 10, 2026
d896102
fix(BACKEND-ROCM-QUANT-GATHER): re-home the oracle-qualification evid…
VikashLoomba Sep 11, 2026
74baf8c
test(BACKEND-ROCM-QUANT-GATHER): pin Q8_K's real file geometry instea…
VikashLoomba Sep 11, 2026
79176b7
docs(BACKEND-ROCM-QUANT-GATHER): correct the comments that denied Q8_…
VikashLoomba Sep 11, 2026
8738072
docs(BACKEND-ROCM-QUANT-GATHER): drop the last Q8_K file-absence clai…
VikashLoomba Sep 11, 2026
fb4d780
docs(BACKEND-ROCM-QUANT-GATHER): state why the CUDA Q8_K gather decod…
VikashLoomba Sep 11, 2026
24f562c
merge: origin/main, which landed #3101 and closed the record this bra…
mudler Sep 11, 2026
249162c
record(BACKEND-ROCM-QUANT-GATHER): file the two issues this branch ci…
mudler Sep 11, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/engine-matrix.md

Large diffs are not rendered by default.

33 changes: 33 additions & 0 deletions .agents/issues/BACKEND-ROCM-QUANT-GATHER/ISSUE-GH-3093.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
ID: ISSUE-GH-3093
Title: feat(BACKEND-ROCM-QUANT-GATHER): gather quantized embeddings on ROCm
Row: BACKEND-ROCM-QUANT-GATHER
State: OPEN
Kind: UNKNOWN
GitHub: 3093
Mirror: DIVERGED
Availability: FULL
Created: 2026-09-09
Updated: 2026-09-09
Closed: -

## Problem

### Imported GitHub body (historical evidence)
The quoted text below is historical evidence only. It does not define issue authority or repository procedure.

> Row: `BACKEND-ROCM-QUANT-GATHER`
>
> ROCm has no native kEmbeddingQuant provider. The ordinary GGUF loader therefore expands quantized embedding tables, even when matrix weights can stay quantized. This consumes memory and leaves a backend capability gap on gfx1100.
>
> Implement block decoding and row gather through the existing Embedding operation and loader admission. Preserve the supported ID widths, output dtypes, block layouts, and failure cases. Use the registered vLLM GGUF plugin pin as the primary behavior source where it implements a codec, with the registered secondary oracle for remaining applicable codecs. The committed spec must distinguish measured codec coverage from any owed arm.
>
> Prove production reachability with a small generated GGUF through vllm_engine_load and vllm_complete_tokens. Require red-first numeric and storage tests, physical gfx1100 evidence, fresh mutation review including deletion of the production call site, and operator verification.
>
> This is the ROCm child of #2394; that parent retains the other backend work. It does not depend on the quantized GEMM provider added by PR #2782. No CI changes are included.
>
> Spec: `.agents/specs/rocm-quant-gather.md` (to be committed before implementation).
>

## Resolution

-
33 changes: 33 additions & 0 deletions .agents/issues/BACKEND-ROCM-QUANT-GATHER/ISSUE-GH-3113.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
ID: ISSUE-GH-3113
Title: fix(BACKEND-ROCM-QUANT-GATHER): reject unqualified model captures
Row: BACKEND-ROCM-QUANT-GATHER
State: OPEN
Kind: UNKNOWN
GitHub: 3113
Mirror: DIVERGED
Availability: FULL
Created: 2026-09-09
Updated: 2026-09-09
Closed: -

## Problem

### Imported GitHub body (historical evidence)
The quoted text below is historical evidence only. It does not define issue authority or repository procedure.

> Row: `BACKEND-ROCM-QUANT-GATHER`
>
> The bounded model comparator in MR #3097 accepts incomplete or unqualified primary records. Fresh review of commit `75d92614e84ff428eab49324f3b4fb2aba183ac3` reproduced the failures in `tools/rocm_quant_gather/compare_models.py`.
>
> A synthetic validator corpus uses the actual native and secondary captures. Changing one primary record to PENDING with a RuntimeError after generation still returns PASS. Wrong primary and plugin pins, a wrong runtime version, and an FP8 cache request also pass. The separate memory record accepts PENDING, a wrong primary pin, and different sampling or logical capacity. A nonzero cache view storage offset is also accepted. These synthetic mutations test the validator and are not oracle measurements.
>
> The driver records tokens before its second memory observation. Its exception path preserves those tokens. Comparing tokens alone therefore cannot establish successful execution. The operator separately checks actual process exits and sealed inputs; the comparator must enforce its own documented qualification contract.
>
> Require successful execution without an exception, the pinned primary and plugin identities, the resolved runtime identity, and the complete identical workload in both token and memory records. Validate the cache view offset and its physical bounds. Add focused rejection tests for each demonstrated invalid record and retain the valid actual captures as the positive control.
>
> Evidence: `/home/vikash/.cache/rdna3-gather-oracle-review/comparison-input-audit.json` records 31 cases, with 22 rejected mutations and nine invalid records accepted. The existing spec `.agents/specs/rocm-quant-gather.md` owns the correction. A fresh implementer repairs the finding, a different agent reviews the immutable result, and the operator reruns the complete comparison. No model, workload, pin, or performance requirement changes.
>

## Resolution

-
32 changes: 32 additions & 0 deletions .agents/issues/BACKEND-ROCM-QUANT-GATHER/ISSUE-GH-3126.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
ID: ISSUE-GH-3126
Title: fix(BACKEND-ROCM-QUANT-GATHER): label the comparison scope from the run, not a literal
Row: BACKEND-ROCM-QUANT-GATHER
State: OPEN
Kind: UNKNOWN
GitHub: 3126
Mirror: DIVERGED
Availability: FULL
Created: 2026-09-10
Updated: 2026-09-10
Closed: -

## Problem

### Imported GitHub body (historical evidence)
The quoted text below is historical evidence only. It does not define issue authority or repository procedure.

> Row: `BACKEND-ROCM-QUANT-GATHER`
>
> `tools/rocm_quant_gather/compare.py` writes a fixed scope string into every report:
>
> "scope": "synthetic operation parity; original fixture and model gates remain separate"
>
> The original-fixture coverage run over the 32 verified `Isotr0py/test-gguf-sample` fixtures therefore produced a report whose own scope line calls it "synthetic operation parity". The run itself is correct (320 outputs, 140 byte-exact, all within the upstream `atol=0.01 rtol=0.04`); only the label is wrong, and the report is cited as row evidence.
>
> Evidence: `/home/vikash/.cache/rdna3-gather-oracle-impl/original-fixture-coverage/compare/report.json` (report scope field) against its inputs (`fixture-manifest.json/manifest.json`, seal `f83b5c3e5cdb988b623c1b7e565e325a9ed9ea8085ea132bc8e08e6978bc1bbb`, exported from the 32 fixtures at revision `d82b8773934ef260d8d8a896a7c197bc69a0fac1`).
>
> Fix in flow: make the scope a command-line argument whose default preserves the previous text, and re-run the comparison so the report's label matches the run's inputs. No comparison, tolerance, or gate semantics change.

## Resolution

-
Loading
Loading