Skip to content

Re-derive gfx1100 decode-graph activation on current main with device and replay proof #3041

Description

@VikashLoomba

Row: BACKEND-ROCM

Re-derive the gfx1100 decode-graph activation on current main. This issue supplies canonical implementation ownership for the unresolved work in #2774 and PR #2777. Their historical GFX1100-TG200 label is not a current roadmap/backend row. The original author owns those records; this issue preserves their provenance instead of rewriting their history.

At main f98b638673b4d2edc0250eec56d229357ea38ab1, the ROCm backend implements HIP graph capture/replay, but the platform leaves static graph admission false. The current #2777 head d79eded33fa2701f3ed0c1d0078c9411110b4939 is cumulative and its activation/test slice still has three independently inspected gaps:

  • Admission queries physical device 0 rather than the executing queue's device index.
  • The advertised explicit opt-in on other architectures remains a hard restriction.
  • The production test checks device allocation, without completed output comparisons or a witness that graph replay executed.

The first deliverable is a committed bounded spec on current main, with active-vLLM pin e126687a9a828d513c01a07cd69f025f27d63280, exact device/model admission, explicit-on/off/default behavior, and a production correctness gate before activation acceptance. Scope must preserve existing shared graph, retained scratch, provider, dtype and sampling mechanisms. Keep the #2943 pointer-cache negative and all historical performance evidence, with their limitations.

The implementation must use the existing ModelRegistry/graph/backend path and prove capture and real replay. Its gate needs independently initialized eager/graph state, completed numerical outputs, changing token/position/block/GDN-slot metadata, shape/slot transitions, scratch growth, recapture and outstanding-work teardown within the admitted scope. A fresh reviewer must delete the production launch/replay call and freeze metadata to prove the tests detect those defects. Unsupported device or model modes must remain explicitly bounded rather than inheriting an untested broad activation.

Fresh implementation, mutation review and operator gates are required. The operator holds the local GPU mutex. Performance acceptance follows correctness and uses the same binary, matched controls and profiler, idle interleaved runs, source/binary/model identities, throughput, latency and memory. Historical contended numbers do not establish a current-main benefit. #2773 remains the owner of state/numerical characterization and its unresolved oracle checks.

The landing PR must link this issue and its committed spec. No merge or throughput acceptance is implied by filing it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions