Repository navigation
fix(ui): keep backends off the add-on browse list - #12878
Merged
Merged
Conversation
The add-on Browse list showed backend entries next to add-ons, with their own install flow. Backends belong on the Backends page, where the library chips already cover them. Ask the library for add-ons only and drop any entry that still says it is a backend. Entries with no kind stay add-ons. Remove the backend-only install flow from the Browse view. Assisted-by: Claude:claude-sonnet-5-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The add-on Browse list showed backend entries next to add-ons, each with its own install flow. Backends belong on the Backends page, so they are now kept off the add-on pages.
kind: addon(the host default) instead ofall, so totals and paging count add-ons only. It also drops any entry that still reportskind: backend. Entries with no kind stay add-ons.BrowseView.jsx: removedinstallBackend,backendWork,installedBackends, the backend branch ofopenInstall, the backend confirm dialog and the backend-only facts. The add-on install and turn-on flow is unchanged.Tests
npm run test:unitincore/http/react-ui: 197 passed, 0 failed. Added a case that backend entries are dropped and no-kind entries are kept; updated the dispatch-shape and backend-entry cases.npm run build: succeeds.e2e/addons-backend-library.spec.jsnow expects a backend entry to be absent from the Browse tab (andkind: addonin the search request). The backend install specs on the Browse tab were removed. This spec was not run here because it needs the Go test server and a browser; CI runs it.