Repository navigation
fix(ci): make master green after the library merge - #12855
Merged
Merged
Conversation
The library change added InstallLibraryBackend to the LocalAIClient interface, but the stub in the MCP endpoint test was not updated. The mcp test package no longer compiled, which failed golangci-lint and stopped the Ginkgo run in tests-linux and tests-apple. The same change added the official_libraries setting, so the Settings page now shows 55 settings plus the three branding images. Update the count the grouping spec expects from 57 to 58. Assisted-by: Claude:claude-sonnet-5-5 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master has been red since the library change (#12816). Three jobs failed. Two of them share one cause.
Failures and fixes
golangci-lint:
core/http/endpoints/mcp/localai_assistant_test.godid not compile. The library change addedInstallLibraryBackendtolocalaitools.LocalAIClient, and the teststubClientwas not updated. The code is right and the test was out of date. Fix: add the method to the stub.tests-linux and tests-apple: the Ginkgo run exits with code 2, but no spec fails. Ginkgo reports
Failed to compile mcpfor the same stub error as in (1). The "Ran 132 of 154 Specs" line belongs to a different suite that passed. Both jobs are fixed by the change in (1).tests-ui-e2e,
settings-page.spec.js, "every real field sits in exactly one group": the page now shows 58 fields, the spec expected 57. The library change added theofficial_librariessetting ("Use official libraries") tosettingsSchema.js, in the backends group. Each field is in exactly one group, and the setting count went from 57 to 58 in the schema (55 settings plus the three branding images). The count is the intended one, so the spec now expects 58 (the check and the "Search all N settings" label). The read-only gallery view is not the cause.The "protoc-gen-go: program not found" message
Warning text only. The Makefile echoes a recipe comment that contains that phrase. The
protogen-gorecipe puts the Go bin directory onPATH, and the generated files were built in every job. It is not a real problem.Run here
go vetoncore/http/endpoints/mcpandpkg/mcp/localaitools/...: clean.core/http/endpoints/mcpandpkg/mcp/localaitools/...(4 suites): all passed, including the 55 localaitools specs and 25 httpapi specs.npm run test:unit): 180 passed, 0 failed.e2e/settings-page.spec.jsagainst a locally built test server (system Chrome): before the fix 28 passed and 1 failed (received 58); after the fix 29 passed.Not run here
go vetresult covers the compile error it reported in CI.