ENH: Record which muTopOpt and which muGrid produced a run - #12
Merged
Merged
Conversation
A result is only interpretable against the build that produced it: the numerics live in muGrid, and a muGrid change can move CG iteration counts on its own (the block-count cap in 1.1.1's GPU reductions reorders every dot product above 64^3, for instance). Historic runs recorded neither version, so two logs that disagree cannot be attributed. muGrid stamps a git-derived version into its build; muTopOpt's __version__ is a hand-written constant that does not move between commits, so version.py derives the commit from the checkout instead, and marks a dirty working tree -- a run from modified sources is not reproducible from its commit alone. Both banners now print right after the solver is constructed, ahead of the target checks and the restart read, so a run that dies in setup still says what it was. They are also written to the output file next to command_line: that attribute records what was asked for, these record what ran it. The file's copies deliberately carry no communicator or device -- those make muGrid's string rank-dependent (rank 2/4, device cuda:2), and a global attribute is written collectively. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A result is only interpretable against the build that produced it: the numerics live in muGrid, and a muGrid change can move CG iteration counts on its own (the block-count cap in 1.1.1's GPU reductions reorders every dot product above 64^3, for instance). Historic runs recorded neither version, so two logs that disagree cannot be attributed.
muGrid stamps a git-derived version into its build; muTopOpt's version is a hand-written constant that does not move between commits, so version.py derives the commit from the checkout instead, and marks a dirty working tree -- a run from modified sources is not reproducible from its commit alone.
Both banners now print right after the solver is constructed, ahead of the target checks and the restart read, so a run that dies in setup still says what it was. They are also written to the output file next to command_line: that attribute records what was asked for, these record what ran it. The file's copies deliberately carry no communicator or device -- those make muGrid's string rank-dependent (rank 2/4, device cuda:2), and a global attribute is written collectively.