Drop Support for .NET 8.0 - #35
Merged
Merged
Conversation
devinlyons
requested review from
Eddonomochi,
RJSonnenberg,
bjhull,
mleone11 and
sambolias
and
a lite review from Copilot
August 12, 2026 19:27
|
🔗 Jira task created: SOF-668 |
mleone11
approved these changes
Aug 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the repository to no longer target .NET 8 by moving projects to .NET 10, along with associated dependency/tooling updates across src, tests, samples, and CI.
Changes:
- Retargets library, test, and sample projects from
net8.0tonet10.0and updatesFSharp.Coreranges/versions accordingly. - Migrates test dependencies to the xUnit v3 ecosystem and removes now-unneeded test
Program.fsentrypoints. - Replaces the legacy
.slnwith an XML.slnxsolution and updates GitHub Actions to install the .NET 10 SDK.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/FSharp.Data.Validation.Tests/Program.fs | Removes manual test entrypoint source file. |
| tests/FSharp.Data.Validation.Tests/FSharp.Data.Validation.Tests.fsproj | Retargets to net10 and updates test package references (xUnit v3, FsCheck v3, etc.). |
| tests/FSharp.Data.Validation.Async.Tests/Tests.fs | Adjusts the test module name for the async test project. |
| tests/FSharp.Data.Validation.Async.Tests/Program.fs | Removes manual test entrypoint source file. |
| tests/FSharp.Data.Validation.Async.Tests/FSharp.Data.Validation.Async.Tests.fsproj | Retargets to net10 and updates test package references (xUnit v3, FsCheck v3, etc.). |
| src/FSharp.Data.Validation/FSharp.Data.Validation.fsproj | Retargets core library to net10 and bumps minimum FSharp.Core. |
| src/FSharp.Data.Validation.Giraffe/FSharp.Data.Validation.Giraffe.fsproj | Retargets to net10, bumps minimum FSharp.Core, and updates Giraffe dependency range. |
| src/FSharp.Data.Validation.Async/FSharp.Data.Validation.Async.fsproj | Retargets async library to net10 and bumps minimum FSharp.Core. |
| src/Directory.Build.props | Pins Microsoft.SourceLink.GitHub to a specific version. |
| samples/GettingStarted/packages.lock.json | Updates lockfile TFM and FSharp.Core resolution to net10-compatible versions. |
| samples/GettingStarted/GettingStarted.fsproj | Retargets sample to net10 and bumps minimum FSharp.Core. |
| samples/FSharp.Data.Validation.Samples/packages.lock.json | Updates lockfile TFM and FSharp.Core resolution to net10-compatible versions. |
| samples/FSharp.Data.Validation.Samples/FSharp.Data.Validation.Samples.fsproj | Retargets sample to net10 and bumps minimum FSharp.Core. |
| FSharp.Data.Validation.slnx | Adds new .slnx solution file listing all projects. |
| FSharp.Data.Validation.sln | Removes legacy .sln solution file. |
| .github/workflows/test.yml | Updates CI to install .NET 10 SDK. |
| .github/workflows/release.yml | Updates release workflow to install .NET 10 SDK. |
| .github/workflows/giraffe-release.yml | Updates Giraffe release workflow to install .NET 10 SDK. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Eddonomochi
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.