Skip to content

Drop Support for .NET 8.0 - #35

Merged
devinlyons merged 2 commits into
mainfrom
drop-support-for-dotnet-8
Aug 12, 2026
Merged

devinlyons merged 2 commits into
mainfrom
drop-support-for-dotnet-8

Conversation

@devinlyons

Copy link
Copy Markdown
Contributor

No description provided.

@devinlyons
devinlyons requested review from Eddonomochi, RJSonnenberg, bjhull, mleone11 and sambolias and a lite review from Copilot August 12, 2026 19:27
@devinlyons devinlyons self-assigned this Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

🔗 Jira task created: SOF-668

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository to no longer target .NET 8 by moving projects to .NET 10, along with associated dependency/tooling updates across src, tests, samples, and CI.

Changes:

  • Retargets library, test, and sample projects from net8.0 to net10.0 and updates FSharp.Core ranges/versions accordingly.
  • Migrates test dependencies to the xUnit v3 ecosystem and removes now-unneeded test Program.fs entrypoints.
  • Replaces the legacy .sln with an XML .slnx solution and updates GitHub Actions to install the .NET 10 SDK.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/FSharp.Data.Validation.Tests/Program.fs Removes manual test entrypoint source file.
tests/FSharp.Data.Validation.Tests/FSharp.Data.Validation.Tests.fsproj Retargets to net10 and updates test package references (xUnit v3, FsCheck v3, etc.).
tests/FSharp.Data.Validation.Async.Tests/Tests.fs Adjusts the test module name for the async test project.
tests/FSharp.Data.Validation.Async.Tests/Program.fs Removes manual test entrypoint source file.
tests/FSharp.Data.Validation.Async.Tests/FSharp.Data.Validation.Async.Tests.fsproj Retargets to net10 and updates test package references (xUnit v3, FsCheck v3, etc.).
src/FSharp.Data.Validation/FSharp.Data.Validation.fsproj Retargets core library to net10 and bumps minimum FSharp.Core.
src/FSharp.Data.Validation.Giraffe/FSharp.Data.Validation.Giraffe.fsproj Retargets to net10, bumps minimum FSharp.Core, and updates Giraffe dependency range.
src/FSharp.Data.Validation.Async/FSharp.Data.Validation.Async.fsproj Retargets async library to net10 and bumps minimum FSharp.Core.
src/Directory.Build.props Pins Microsoft.SourceLink.GitHub to a specific version.
samples/GettingStarted/packages.lock.json Updates lockfile TFM and FSharp.Core resolution to net10-compatible versions.
samples/GettingStarted/GettingStarted.fsproj Retargets sample to net10 and bumps minimum FSharp.Core.
samples/FSharp.Data.Validation.Samples/packages.lock.json Updates lockfile TFM and FSharp.Core resolution to net10-compatible versions.
samples/FSharp.Data.Validation.Samples/FSharp.Data.Validation.Samples.fsproj Retargets sample to net10 and bumps minimum FSharp.Core.
FSharp.Data.Validation.slnx Adds new .slnx solution file listing all projects.
FSharp.Data.Validation.sln Removes legacy .sln solution file.
.github/workflows/test.yml Updates CI to install .NET 10 SDK.
.github/workflows/release.yml Updates release workflow to install .NET 10 SDK.
.github/workflows/giraffe-release.yml Updates Giraffe release workflow to install .NET 10 SDK.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/FSharp.Data.Validation/FSharp.Data.Validation.fsproj
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/giraffe-release.yml
@devinlyons
devinlyons merged commit d68bbfc into main Aug 12, 2026
1 check passed
@devinlyons
devinlyons deleted the drop-support-for-dotnet-8 branch August 12, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants